* [PATCH] thermal: cpu_cooling: pr_err() strings should end with newlines
@ 2017-10-24 7:50 Arvind Yadav
2017-10-25 15:20 ` Javi Merino
2017-10-26 3:44 ` Viresh Kumar
0 siblings, 2 replies; 3+ messages in thread
From: Arvind Yadav @ 2017-10-24 7:50 UTC (permalink / raw)
To: amit.kachhap, viresh.kumar, javi.merino, rui.zhang, edubezval
Cc: linux-kernel, linux-pm
pr_err() messages should end with a new-line to avoid other messages
being concatenated.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/thermal/cpu_cooling.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c
index 908a801..dc63aba 100644
--- a/drivers/thermal/cpu_cooling.c
+++ b/drivers/thermal/cpu_cooling.c
@@ -696,7 +696,7 @@ static unsigned int find_next_max(struct cpufreq_frequency_table *table,
bool first;
if (IS_ERR_OR_NULL(policy)) {
- pr_err("%s: cpufreq policy isn't valid: %p", __func__, policy);
+ pr_err("%s: cpufreq policy isn't valid: %p\n", __func__, policy);
return ERR_PTR(-EINVAL);
}
--
1.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] thermal: cpu_cooling: pr_err() strings should end with newlines
2017-10-24 7:50 [PATCH] thermal: cpu_cooling: pr_err() strings should end with newlines Arvind Yadav
@ 2017-10-25 15:20 ` Javi Merino
2017-10-26 3:44 ` Viresh Kumar
1 sibling, 0 replies; 3+ messages in thread
From: Javi Merino @ 2017-10-25 15:20 UTC (permalink / raw)
To: Arvind Yadav
Cc: amit.kachhap, viresh.kumar, rui.zhang, edubezval, linux-kernel, linux-pm
On Tue, Oct 24, 2017 at 01:20:39PM +0530, Arvind Yadav wrote:
> pr_err() messages should end with a new-line to avoid other messages
> being concatenated.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
FWIW,
Acked-by: Javi Merino <javi.merino@kernel.org>
> ---
> drivers/thermal/cpu_cooling.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c
> index 908a801..dc63aba 100644
> --- a/drivers/thermal/cpu_cooling.c
> +++ b/drivers/thermal/cpu_cooling.c
> @@ -696,7 +696,7 @@ static unsigned int find_next_max(struct cpufreq_frequency_table *table,
> bool first;
>
> if (IS_ERR_OR_NULL(policy)) {
> - pr_err("%s: cpufreq policy isn't valid: %p", __func__, policy);
> + pr_err("%s: cpufreq policy isn't valid: %p\n", __func__, policy);
> return ERR_PTR(-EINVAL);
> }
>
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] thermal: cpu_cooling: pr_err() strings should end with newlines
2017-10-24 7:50 [PATCH] thermal: cpu_cooling: pr_err() strings should end with newlines Arvind Yadav
2017-10-25 15:20 ` Javi Merino
@ 2017-10-26 3:44 ` Viresh Kumar
1 sibling, 0 replies; 3+ messages in thread
From: Viresh Kumar @ 2017-10-26 3:44 UTC (permalink / raw)
To: Arvind Yadav
Cc: amit.kachhap, javi.merino, rui.zhang, edubezval, linux-kernel, linux-pm
On 24-10-17, 13:20, Arvind Yadav wrote:
> pr_err() messages should end with a new-line to avoid other messages
> being concatenated.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/thermal/cpu_cooling.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c
> index 908a801..dc63aba 100644
> --- a/drivers/thermal/cpu_cooling.c
> +++ b/drivers/thermal/cpu_cooling.c
> @@ -696,7 +696,7 @@ static unsigned int find_next_max(struct cpufreq_frequency_table *table,
> bool first;
>
> if (IS_ERR_OR_NULL(policy)) {
> - pr_err("%s: cpufreq policy isn't valid: %p", __func__, policy);
> + pr_err("%s: cpufreq policy isn't valid: %p\n", __func__, policy);
> return ERR_PTR(-EINVAL);
> }
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-26 3:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-24 7:50 [PATCH] thermal: cpu_cooling: pr_err() strings should end with newlines Arvind Yadav
2017-10-25 15:20 ` Javi Merino
2017-10-26 3:44 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®