From: Steven Rostedt <rostedt@goodmis.org>
To: Julien Thierry <julien.thierry@arm.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH] trace: fix undefined tracing functions build error
Date: Thu, 26 Oct 2017 06:55:51 -0400 [thread overview]
Message-ID: <20171026065551.0e8126ba@vmware.local.home> (raw)
In-Reply-To: <1509007060-24191-1-git-send-email-julien.thierry@arm.com>
On Thu, 26 Oct 2017 09:37:40 +0100
Julien Thierry <julien.thierry@arm.com> wrote:
> When selecting CONFIG_PREEMPTIRQ_EVENTS without CONFIG_DEBUG_PREEMPT,
> trace_preempt_(en|dis)able_* names do not get defined. This causes a build
> error in function trace_preempt_off (kernel/trace/trace_irqsoff.c) when
> CONFIG_PREEMPT_TRACER is enabled.
>
> Similarly, when selecting CONFIG_PREEMPTIRQ_EVENTS and
> CONFIG_PROVE_LOCKING, trace_irq_(en|dis)able_* names do not get defined,
> although it seems they do not get referenced in that configuration.
>
> Ensure trace_(irq|preempt)_* names are always defined, becoming empty
> macros in the cases where they were not defined previously.
>
Thanks,
But I've seen another patch that I believe fixes this issue, but I'm
currently traveling in Prague, and attending several conferences there,
and haven't had time to look at my email.
When I get home next week I'll be applying patches sent to me.
Thanks,
-- Steve
next prev parent reply other threads:[~2017-10-26 10:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 8:37 Julien Thierry
2017-10-26 10:55 ` Steven Rostedt [this message]
2017-10-31 17:41 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171026065551.0e8126ba@vmware.local.home \
--to=rostedt@goodmis.org \
--cc=julien.thierry@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®