From: Steven Rostedt <rostedt@goodmis.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
stable <stable@vger.kernel.org>
Subject: Re: [GIT PULL] tracing/samples: Fix creation and deletion of simple_thread_fn creation
Date: Fri, 27 Oct 2017 21:15:27 -0400 [thread overview]
Message-ID: <20171027211527.6ebf5da4@vmware.local.home> (raw)
In-Reply-To: <CA+55aFyR_FB=mYEgVnLmmkD_SLnSe9a28+LjOg=tPxj4gYtyhA@mail.gmail.com>
On Fri, 27 Oct 2017 16:59:49 -0700
Linus Torvalds <torvalds@linux-foundation.org> wrote:
> I'm back home, which means I do full builds, and that in turn shows
> that this was garbage.
Unfortunately, I'm still in Prague, but I just finished my marathon of
presentations.
>
> On Tue, Oct 17, 2017 at 2:21 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > Please pull the latest trace-v4.14-rc3 tree, which can be found at:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
> > trace-v4.14-rc3
>
> This causes a compiler warning, for a very valid reason:
>
> > +static bool simple_thread_cnt;
> >
> > int foo_bar_reg(void)
> > {
> > + mutex_lock(&thread_mutex);
> > + if (simple_thread_cnt++)
> > + goto out;
>
> Yeah., take a closer look at that. It's complete and utter BS.
>
> Please send a fix asap, or I'll just revert.
Yes, it is. Being sample code it doesn't get tested in my test suite (I
should fix that) and this is the first pull request I sent you that
didn't go through the testing (because my test suit wouldn't even test
it).
I'll write up a fix on the plane home on Saturday. Expect something by
Sunday.
Sorry about that. :-/
-- Steve
next prev parent reply other threads:[~2017-10-28 1:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 21:21 Steven Rostedt
2017-10-27 23:59 ` Linus Torvalds
2017-10-28 1:15 ` Steven Rostedt [this message]
2017-10-28 3:35 ` Linus Torvalds
2017-10-29 20:17 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171027211527.6ebf5da4@vmware.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome