* [watchdog] watchdog: mei_wdt: don't use of variable length array
@ 2017-10-29 7:51 Tomas Winkler
2017-10-29 22:43 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Tomas Winkler @ 2017-10-29 7:51 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck
Cc: linux-watchdog, linux-kernel, Tomas Winkler
Fixes sparse warning:
drivers/watchdog/mei_wdt.c:530:18: warning: Variable length array is used
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Reviewed-by: Alexander Usyskin <alexander.usyskin@intel.com>
---
drivers/watchdog/mei_wdt.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/watchdog/mei_wdt.c b/drivers/watchdog/mei_wdt.c
index ea60b29494fb..b8194b02abe0 100644
--- a/drivers/watchdog/mei_wdt.c
+++ b/drivers/watchdog/mei_wdt.c
@@ -526,12 +526,11 @@ static ssize_t mei_dbgfs_read_state(struct file *file, char __user *ubuf,
size_t cnt, loff_t *ppos)
{
struct mei_wdt *wdt = file->private_data;
- const size_t bufsz = 32;
- char buf[bufsz];
+ char buf[32];
ssize_t pos;
- pos = scnprintf(buf, bufsz, "state: %s\n",
- mei_wdt_state_str(wdt->state));
+ pos = scnprintf(buf, sizeof(buf), "state: %s\n",
+ mei_wdt_state_str(wdt->state));
return simple_read_from_buffer(ubuf, cnt, ppos, buf, pos);
}
--
2.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [watchdog] watchdog: mei_wdt: don't use of variable length array
2017-10-29 7:51 [watchdog] watchdog: mei_wdt: don't use of variable length array Tomas Winkler
@ 2017-10-29 22:43 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2017-10-29 22:43 UTC (permalink / raw)
To: Tomas Winkler, Wim Van Sebroeck; +Cc: linux-watchdog, linux-kernel
On 10/29/2017 12:51 AM, Tomas Winkler wrote:
> Fixes sparse warning:
> drivers/watchdog/mei_wdt.c:530:18: warning: Variable length array is used
>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> Reviewed-by: Alexander Usyskin <alexander.usyskin@intel.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/mei_wdt.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/watchdog/mei_wdt.c b/drivers/watchdog/mei_wdt.c
> index ea60b29494fb..b8194b02abe0 100644
> --- a/drivers/watchdog/mei_wdt.c
> +++ b/drivers/watchdog/mei_wdt.c
> @@ -526,12 +526,11 @@ static ssize_t mei_dbgfs_read_state(struct file *file, char __user *ubuf,
> size_t cnt, loff_t *ppos)
> {
> struct mei_wdt *wdt = file->private_data;
> - const size_t bufsz = 32;
> - char buf[bufsz];
> + char buf[32];
> ssize_t pos;
>
> - pos = scnprintf(buf, bufsz, "state: %s\n",
> - mei_wdt_state_str(wdt->state));
> + pos = scnprintf(buf, sizeof(buf), "state: %s\n",
> + mei_wdt_state_str(wdt->state));
>
> return simple_read_from_buffer(ubuf, cnt, ppos, buf, pos);
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-29 22:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-29 7:51 [watchdog] watchdog: mei_wdt: don't use of variable length array Tomas Winkler
2017-10-29 22:43 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®