* [PATCH] media: atmel-isc: Fix clock ID for clk_prepare/unprepare
@ 2017-10-30 0:46 Wenyou Yang
2017-10-30 13:44 ` Sakari Ailus
0 siblings, 1 reply; 2+ messages in thread
From: Wenyou Yang @ 2017-10-30 0:46 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: linux-kernel, Nicolas Ferre, Sakari Ailus, Jonathan Corbet,
Hans Verkuil, linux-arm-kernel, Linux Media Mailing List,
Wenyou Yang
Fix the clock ID to do the runtime pm should be ISC_ISPCK,
instead of ISC_MCK in clk_prepare(), clk_unprepare() and
isc_clk_is_enabled().
Signed-off-by: Wenyou Yang <wenyou.yang@microchip.com>
---
drivers/media/platform/atmel/atmel-isc.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/media/platform/atmel/atmel-isc.c b/drivers/media/platform/atmel/atmel-isc.c
index 2c40a7886542..9294ff0c7b83 100644
--- a/drivers/media/platform/atmel/atmel-isc.c
+++ b/drivers/media/platform/atmel/atmel-isc.c
@@ -598,7 +598,7 @@ static int isc_clk_prepare(struct clk_hw *hw)
{
struct isc_clk *isc_clk = to_isc_clk(hw);
- if (isc_clk->id == ISC_MCK)
+ if (isc_clk->id == ISC_ISPCK)
pm_runtime_get_sync(isc_clk->dev);
return isc_wait_clk_stable(hw);
@@ -610,7 +610,7 @@ static void isc_clk_unprepare(struct clk_hw *hw)
isc_wait_clk_stable(hw);
- if (isc_clk->id == ISC_MCK)
+ if (isc_clk->id == ISC_ISPCK)
pm_runtime_put_sync(isc_clk->dev);
}
@@ -657,12 +657,12 @@ static int isc_clk_is_enabled(struct clk_hw *hw)
struct isc_clk *isc_clk = to_isc_clk(hw);
u32 status;
- if (isc_clk->id == ISC_MCK)
+ if (isc_clk->id == ISC_ISPCK)
pm_runtime_get_sync(isc_clk->dev);
regmap_read(isc_clk->regmap, ISC_CLKSR, &status);
- if (isc_clk->id == ISC_MCK)
+ if (isc_clk->id == ISC_ISPCK)
pm_runtime_put_sync(isc_clk->dev);
return status & ISC_CLK(isc_clk->id) ? 1 : 0;
--
2.13.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] media: atmel-isc: Fix clock ID for clk_prepare/unprepare
2017-10-30 0:46 [PATCH] media: atmel-isc: Fix clock ID for clk_prepare/unprepare Wenyou Yang
@ 2017-10-30 13:44 ` Sakari Ailus
0 siblings, 0 replies; 2+ messages in thread
From: Sakari Ailus @ 2017-10-30 13:44 UTC (permalink / raw)
To: Wenyou Yang
Cc: Mauro Carvalho Chehab, linux-kernel, Nicolas Ferre,
Jonathan Corbet, Hans Verkuil, linux-arm-kernel,
Linux Media Mailing List
On Mon, Oct 30, 2017 at 08:46:50AM +0800, Wenyou Yang wrote:
> Fix the clock ID to do the runtime pm should be ISC_ISPCK,
> instead of ISC_MCK in clk_prepare(), clk_unprepare() and
> isc_clk_is_enabled().
>
> Signed-off-by: Wenyou Yang <wenyou.yang@microchip.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
--
Sakari Ailus
e-mail: sakari.ailus@iki.fi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-30 13:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-30 0:46 [PATCH] media: atmel-isc: Fix clock ID for clk_prepare/unprepare Wenyou Yang
2017-10-30 13:44 ` Sakari Ailus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®