From: Viresh Kumar <viresh.kumar@linaro.org>
To: Joel Fernandes <joelaf@google.com>
Cc: linux-kernel@vger.kernel.org,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
"Cc: Srinivas Pandruvada" <srinivas.pandruvada@linux.intel.com>,
"Cc: Len Brown" <lenb@kernel.org>,
"Cc: Juri Lelli" <juri.lelli@arm.com>,
"Cc: Patrick Bellasi" <patrick.bellasi@arm.com>,
"Cc: Steve Muckle" <smuckle@google.com>,
"Cc: Brendan Jackman" <brendan.jackman@arm.com>,
"Cc: Chris Redpath" <Chris.Redpath@arm.com>,
"Cc: Atish Patra" <atish.patra@oracle.com>,
"Cc: Dietmar Eggemann" <dietmar.eggemann@arm.com>,
"Cc: Vincent Guittot" <vincent.guittot@linaro.org>,
"Cc: Morten Ramussen" <morten.rasmussen@arm.com>,
"Cc: EAS Dev" <eas-dev@lists.linaro.org>,
"Cc: Android Kernel" <kernel-team@android.com>
Subject: Re: [PATCH RFC 3/5] cpufreq: schedutil: Use idle_calls counter of the remote CPU
Date: Mon, 30 Oct 2017 14:48:29 +0530 [thread overview]
Message-ID: <20171030091829.GM4240@vireshk-i7> (raw)
In-Reply-To: <20171028095941.4773-4-joelaf@google.com>
On 28-10-17, 02:59, Joel Fernandes wrote:
> Since the recent remote cpufreq callback work, its possible that a cpufreq
> update is triggered from a remote CPU. For single policies however, the current
> code uses the local CPU when trying to determine if the remote sg_cpu entered
> idle or is busy. This is incorrect. To remedy this, compare with the nohz tick
> idle_calls counter of the remote CPU.
>
> Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
Fixes: 674e75411fc2 ("sched: cpufreq: Allow remote cpufreq callbacks")
> Signed-off-by: Joel Fernandes <joelaf@google.com>
> ---
> include/linux/tick.h | 1 +
> kernel/sched/cpufreq_schedutil.c | 2 +-
> kernel/time/tick-sched.c | 13 +++++++++++++
> 3 files changed, 15 insertions(+), 1 deletion(-)
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
next prev parent reply other threads:[~2017-10-30 9:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-28 9:59 [PATCH RFC 0/5] sched and cpufreq fixes/cleanups Joel Fernandes
2017-10-28 9:59 ` [PATCH RFC 1/5] Revert "sched/fair: Drop always true parameter of update_cfs_rq_load_avg()" Joel Fernandes
2017-10-28 9:59 ` [PATCH RFC 2/5] sched/fair: Skip frequency update if CPU about to idle Joel Fernandes
2017-10-30 12:07 ` Viresh Kumar
2017-10-30 19:02 ` Joel Fernandes
2017-11-01 19:35 ` Steve Muckle
2017-11-04 5:44 ` Joel Fernandes
2017-11-06 8:00 ` Vincent Guittot
2017-11-06 9:29 ` Uladzislau Rezki
2017-11-08 5:11 ` Joel Fernandes
2017-10-28 9:59 ` [PATCH RFC 3/5] cpufreq: schedutil: Use idle_calls counter of the remote CPU Joel Fernandes
2017-10-30 9:18 ` Viresh Kumar [this message]
2017-10-28 9:59 ` [PATCH RFC 4/5] sched/fair: Correct obsolete comment about cpufreq_update_util Joel Fernandes
2017-10-30 9:22 ` Viresh Kumar
2017-10-30 19:16 ` Joel Fernandes
2017-10-28 9:59 ` [PATCH RFC 5/5] sched/fair: remove impossible condition from find_idlest_group_cpu Joel Fernandes
2017-10-30 15:41 ` Brendan Jackman
2017-10-30 16:00 ` Vincent Guittot
2017-10-30 16:19 ` Joel Fernandes
2017-10-30 16:26 ` Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171030091829.GM4240@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=Chris.Redpath@arm.com \
--cc=atish.patra@oracle.com \
--cc=brendan.jackman@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=eas-dev@lists.linaro.org \
--cc=fweisbec@gmail.com \
--cc=joelaf@google.com \
--cc=juri.lelli@arm.com \
--cc=kernel-team@android.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=patrick.bellasi@arm.com \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=smuckle@google.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®