From: Daniel Vetter <daniel@ffwll.ch>
To: Pan Bian <bianpan2016@163.com>
Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>,
David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: gma500: mmu: unmap the correct address
Date: Mon, 30 Oct 2017 11:22:24 +0100 [thread overview]
Message-ID: <20171030102224.55gyvgehpwzgn2f6@phenom.ffwll.local> (raw)
In-Reply-To: <1509256512-5962-1-git-send-email-bianpan2016@163.com>
On Sun, Oct 29, 2017 at 01:55:12PM +0800, Pan Bian wrote:
> The function kunmap_atomatic() is called on the same variable twice,
> i.e. pt->v. In the second call, its parameter should be variable v
> rather than pt->v.
>
> Signed-off-by: Pan Bian <bianpan2016@163.com>
Makes sense, not sure this ever worked or how it ever worked, but oh well.
Applied to drm-misc-next for 4.16.
-Daniel
> ---
> drivers/gpu/drm/gma500/mmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/gma500/mmu.c b/drivers/gpu/drm/gma500/mmu.c
> index 0eaf11c..ccb161c 100644
> --- a/drivers/gpu/drm/gma500/mmu.c
> +++ b/drivers/gpu/drm/gma500/mmu.c
> @@ -395,7 +395,7 @@ static void psb_mmu_pt_unmap_unlock(struct psb_mmu_pt *pt)
> psb_mmu_clflush(pd->driver, (void *)&v[pt->index]);
> atomic_set(&pd->driver->needs_tlbflush, 1);
> }
> - kunmap_atomic(pt->v);
> + kunmap_atomic(v);
> spin_unlock(&pd->driver->lock);
> psb_mmu_free_pt(pt);
> return;
> --
> 1.9.1
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
prev parent reply other threads:[~2017-10-30 10:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-29 5:55 Pan Bian
2017-10-30 10:22 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171030102224.55gyvgehpwzgn2f6@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@linux.ie \
--cc=bianpan2016@163.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrik.r.jakobsson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®