From: Herbert Xu <herbert@gondor.apana.org.au>
To: Gilad Ben-Yossef <gilad@benyossef.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Ofir Drang <ofir.drang@arm.com>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: testmgr: don't allocate IV on stack
Date: Tue, 31 Oct 2017 15:59:25 +0800 [thread overview]
Message-ID: <20171031075925.GA26147@gondor.apana.org.au> (raw)
In-Reply-To: <1509436586-17500-1-git-send-email-gilad@benyossef.com>
On Tue, Oct 31, 2017 at 07:56:26AM +0000, Gilad Ben-Yossef wrote:
> The IV was allocated on the stack in testmgr skcipher tests.
> Since HW based tfm providers need to DMA the IV to the HW,
> this leads to problems and is detected by the DMA-API debug
> code.
>
> Fix it by allocating the IV using kmalloc instead.
>
> Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
The driver that is mapping the IV directly should be fixed instead.
Only input that is given in the form of SG lists can be mapped.
Everything else should be copied if they need to go over DMA.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2017-10-31 8:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 7:56 Gilad Ben-Yossef
2017-10-31 7:59 ` Herbert Xu [this message]
2017-10-31 8:05 ` Gilad Ben-Yossef
2017-10-31 9:05 ` Horia Geantă
2017-10-31 10:19 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171031075925.GA26147@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=gilad@benyossef.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ofir.drang@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®