From: Namhyung Kim <namhyung@kernel.org>
To: Jiri Olsa <jolsa@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>, David Ahern <dsahern@gmail.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
kernel-team@lge.com
Subject: Re: [PATCH 0/7] perf tools: Small sample parsing speedup
Date: Wed, 1 Nov 2017 17:39:55 +0900 [thread overview]
Message-ID: <20171101083955.GA25146@danjae.aot.lge.com> (raw)
In-Reply-To: <20171031092947.19410-1-jolsa@kernel.org>
Hi Jiri,
On Tue, Oct 31, 2017 at 10:29:40AM +0100, Jiri Olsa wrote:
> hi,
> sending small speedup fix for sample parsing code
> and few assorted fixes.
Nice work, for patch 1-5:
Acked-by: Namhyung Kim <namhyung@kernel.org>
But I'm not sure for patch 6 and 7 as tool and event arguments are
passed to others consistently.
Thanks,
Namhyung
>
> Also available in:
> https://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
> perf/fixes
>
> thanks,
> jirka
>
>
> ---
> Jiri Olsa (7):
> perf tools: Reset cursor arg instead of callchain_cursor
> perf tools: Centralize perf_sample initialization
> perf tools: Add perf_evlist__parse_sample_timestamp function
> perf tools: Pass timestamp arg in perf_session__queue_event
> perf tools: Optimize sample parsing for ordered events
> perf tools: Remove perf_tool from event_op2
> perf tools: Remove perf_tool from event_op3
>
> tools/perf/builtin-inject.c | 32 ++++++++++++++------------------
> tools/perf/builtin-kvm.c | 8 ++++----
> tools/perf/builtin-script.c | 22 ++++++++++------------
> tools/perf/builtin-stat.c | 23 +++++++++++------------
> tools/perf/util/auxtrace.c | 17 +++++++----------
> tools/perf/util/auxtrace.h | 15 ++++++---------
> tools/perf/util/evlist.c | 11 +++++++++++
> tools/perf/util/evlist.h | 4 ++++
> tools/perf/util/evsel.c | 71 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------
> tools/perf/util/evsel.h | 4 ++++
> tools/perf/util/header.c | 16 +++++++---------
> tools/perf/util/header.h | 15 ++++++---------
> tools/perf/util/machine.c | 2 +-
> tools/perf/util/ordered-events.c | 3 +--
> tools/perf/util/ordered-events.h | 2 +-
> tools/perf/util/session.c | 120 +++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------------------------------------------
> tools/perf/util/session.h | 7 +++----
> tools/perf/util/stat.c | 5 ++---
> tools/perf/util/stat.h | 5 ++---
> tools/perf/util/tool.h | 7 ++-----
> 20 files changed, 208 insertions(+), 181 deletions(-)
next prev parent reply other threads:[~2017-11-01 8:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 9:29 Jiri Olsa
2017-10-31 9:29 ` [PATCH 1/7] perf tools: Reset cursor arg instead of callchain_cursor Jiri Olsa
2017-10-31 9:29 ` [PATCH 2/7] perf tools: Centralize perf_sample initialization Jiri Olsa
2017-10-31 9:29 ` [PATCH 3/7] perf tools: Add perf_evlist__parse_sample_timestamp function Jiri Olsa
2017-10-31 9:29 ` [PATCH 4/7] perf tools: Pass timestamp arg in perf_session__queue_event Jiri Olsa
2017-10-31 9:29 ` [PATCH 5/7] perf tools: Optimize sample parsing for ordered events Jiri Olsa
2017-10-31 9:40 ` Ingo Molnar
2017-10-31 9:29 ` [PATCH 6/7] perf tools: Remove perf_tool from event_op2 Jiri Olsa
2017-10-31 9:29 ` [PATCH 7/7] perf tools: Remove perf_tool from event_op3 Jiri Olsa
2017-11-01 8:39 ` Namhyung Kim [this message]
2017-11-01 11:50 ` [PATCH 0/7] perf tools: Small sample parsing speedup Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171101083955.GA25146@danjae.aot.lge.com \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=jolsa@kernel.org \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome