From: Namhyung Kim <namhyung@kernel.org>
To: "Wangnan (F)" <wangnan0@huawei.com>
Cc: linux-kernel@vger.kernel.org, kan.liang@intel.com,
acme@kernel.org, jolsa@redhat.com, kernel-team@lge.com
Subject: Re: [PATCH 2/2] perf record: Replace 'overwrite' by 'flightrecorder' for better naming
Date: Wed, 1 Nov 2017 21:03:36 +0900 [thread overview]
Message-ID: <20171101120336.GB26623@danjae.aot.lge.com> (raw)
In-Reply-To: <0bd4363a-12f1-d9e1-12b2-82360d397ccb@huawei.com>
On Wed, Nov 01, 2017 at 06:17:26PM +0800, Wangnan (F) wrote:
>
>
> On 2017/11/1 18:03, Namhyung Kim wrote:
> > On Wed, Nov 01, 2017 at 05:53:27AM +0000, Wang Nan wrote:
> > > The meaning of perf record's "overwrite" option and many "overwrite" in
> > > source code are not clear. In perf's code, the 'overwrite' has 2 meanings:
> > > 1. Make ringbuffer readonly (perf_evlist__mmap_ex's argument).
> > > 2. Set evsel's "backward" attribute (in apply_config_terms).
> > >
> > > perf record doesn't use meaning 1 at all, but have a overwrite option, its
> > > real meaning is setting backward.
> > >
> > > This patch separates these two concepts, introduce 'flightrecorder' mode
> > > which is what we really want. It combines these 2 concept together, wraps
> > > them into a record mode. In flight recorder mode, perf only dumps data before
> > > something happen.
> > I'm ok with the it but removing old name looks not good. How about
> > keeping them for a while (as deprecated)?.
>
> Is there a way to hide '--overwrite' from 'perf record --help' and print
> something
> when user really use it?
You can set PARSE_OPT_HIDDEN flag to it.
Thanks,
Namhyung
>
> > And 'flightrecorder' seems too long. Maybe you can use an acronym
> > like FDR or fdr-mode?
>
> fdr-mode is a good name.
>
> Thank you.
>
next prev parent reply other threads:[~2017-11-01 12:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-01 5:53 [PATCH 0/2] perf record: Fix --overwrite and clarify concepts Wang Nan
2017-11-01 5:53 ` [PATCH 1/2] perf mmap: Fix perf backward recording Wang Nan
2017-11-01 9:49 ` Namhyung Kim
2017-11-01 10:32 ` Wangnan (F)
2017-11-01 12:00 ` Namhyung Kim
2017-11-01 12:10 ` Wangnan (F)
2017-11-01 12:39 ` Jiri Olsa
2017-11-01 12:56 ` Wangnan (F)
2017-11-02 15:12 ` Jiri Olsa
2017-11-01 13:57 ` Liang, Kan
2017-11-01 16:12 ` Wangnan (F)
2017-11-01 16:22 ` Liang, Kan
2017-11-02 5:34 ` Namhyung Kim
2017-11-02 13:25 ` Liang, Kan
2017-11-02 14:59 ` Jiri Olsa
2017-11-01 5:53 ` [PATCH 2/2] perf record: Replace 'overwrite' by 'flightrecorder' for better naming Wang Nan
2017-11-01 10:03 ` Namhyung Kim
2017-11-01 10:17 ` Wangnan (F)
2017-11-01 12:03 ` Namhyung Kim [this message]
2017-11-01 13:26 ` Liang, Kan
2017-11-01 14:05 ` Wangnan (F)
2017-11-01 14:22 ` Liang, Kan
2017-11-01 14:44 ` Wangnan (F)
2017-11-01 15:04 ` Liang, Kan
2017-11-01 16:00 ` Wangnan (F)
2017-11-01 16:13 ` Liang, Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171101120336.GB26623@danjae.aot.lge.com \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®