From: Masami Hiramatsu <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kselftest@vger.kernel.org, shuah@kernel.org,
linux-kernel@vger.kernel.org,
Tom Zanussi <tom.zanussi@linux.intel.com>,
Rajvi Jingar <rajvi.jingar@intel.com>
Subject: Re: [PATCH] selftests/ftrace: Introduce exit_pass and exit_fail
Date: Wed, 1 Nov 2017 13:23:40 +0900 [thread overview]
Message-ID: <20171101132340.f700f0081419897798a4b1f3@kernel.org> (raw)
In-Reply-To: <20171031174432.770bd509@gandalf.local.home>
On Tue, 31 Oct 2017 17:44:32 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Tue, 31 Oct 2017 23:51:42 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> > diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/busy_check.tc b/tools/testing/selftests/ftrace/test.d/kprobe/busy_check.tc
> > index 74507db8bbc8..b8701fa0b8f2 100644
> > --- a/tools/testing/selftests/ftrace/test.d/kprobe/busy_check.tc
> > +++ b/tools/testing/selftests/ftrace/test.d/kprobe/busy_check.tc
> > @@ -8,7 +8,7 @@ echo > kprobe_events
> > echo p:myevent _do_fork > kprobe_events
> > test -d events/kprobes/myevent
> > echo 1 > events/kprobes/myevent/enable
> > -echo > kprobe_events && exit 1 # this must fail
> > +echo > kprobe_events && exit_fail
>
> Should we keep the comment about "this must fail", otherwise it may
> look like a mistake. Echoing in kprobe_events returns failure here?
Ah, good catch! I misread the comment is for "exit 1"...
Thank you,
>
> -- Steve
>
>
> > echo 0 > events/kprobes/myevent/enable
> > echo > kprobe_events # this must succeed
> > clear_trace
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2017-11-01 4:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 14:51 Masami Hiramatsu
2017-10-31 21:44 ` Steven Rostedt
2017-11-01 4:23 ` Masami Hiramatsu [this message]
2017-11-01 21:18 ` Shuah Khan
2017-11-03 19:34 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171101132340.f700f0081419897798a4b1f3@kernel.org \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=rajvi.jingar@intel.com \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
--cc=tom.zanussi@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome