* [PATCH] staging: rtlwifi: remove an unused variable
@ 2017-11-02 14:31 Arnd Bergmann
2017-11-02 23:47 ` Kees Cook
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2017-11-02 14:31 UTC (permalink / raw)
To: Greg Kroah-Hartman, Larry Finger, Kalle Valo
Cc: Arnd Bergmann, Ping-Ke Shih, devel, linux-kernel
The timer conversion patch left a variable behind, and this
escaped the build testing:
drivers/staging/rtlwifi/base.c: In function 'rtl_watch_dog_timer_callback':
drivers/staging/rtlwifi/base.c:2167:23: error: unused variable 'hw' [-Werror=unused-variable]
This removes the stale variable as well.
Fixes: f8af6a323368 ("staging: rtlwifi: Convert timers to use timer_setup()")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/staging/rtlwifi/base.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtlwifi/base.c b/drivers/staging/rtlwifi/base.c
index 2c693c7aa9d5..c947def37d31 100644
--- a/drivers/staging/rtlwifi/base.c
+++ b/drivers/staging/rtlwifi/base.c
@@ -2164,7 +2164,6 @@ void rtl_watchdog_wq_callback(void *data)
void rtl_watch_dog_timer_callback(struct timer_list *t)
{
struct rtl_priv *rtlpriv = from_timer(rtlpriv, t, works.watchdog_timer);
- struct ieee80211_hw *hw = rtlpriv->hw;
queue_delayed_work(rtlpriv->works.rtl_wq,
&rtlpriv->works.watchdog_wq, 0);
--
2.9.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rtlwifi: remove an unused variable
2017-11-02 14:31 [PATCH] staging: rtlwifi: remove an unused variable Arnd Bergmann
@ 2017-11-02 23:47 ` Kees Cook
0 siblings, 0 replies; 2+ messages in thread
From: Kees Cook @ 2017-11-02 23:47 UTC (permalink / raw)
To: Arnd Bergmann, Greg Kroah-Hartman
Cc: Larry Finger, Kalle Valo, Ping-Ke Shih, devel, LKML, Stephen Rothwell
On Thu, Nov 2, 2017 at 7:31 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> The timer conversion patch left a variable behind, and this
> escaped the build testing:
>
> drivers/staging/rtlwifi/base.c: In function 'rtl_watch_dog_timer_callback':
> drivers/staging/rtlwifi/base.c:2167:23: error: unused variable 'hw' [-Werror=unused-variable]
>
> This removes the stale variable as well.
>
> Fixes: f8af6a323368 ("staging: rtlwifi: Convert timers to use timer_setup()")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/staging/rtlwifi/base.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/rtlwifi/base.c b/drivers/staging/rtlwifi/base.c
> index 2c693c7aa9d5..c947def37d31 100644
> --- a/drivers/staging/rtlwifi/base.c
> +++ b/drivers/staging/rtlwifi/base.c
> @@ -2164,7 +2164,6 @@ void rtl_watchdog_wq_callback(void *data)
> void rtl_watch_dog_timer_callback(struct timer_list *t)
> {
> struct rtl_priv *rtlpriv = from_timer(rtlpriv, t, works.watchdog_timer);
> - struct ieee80211_hw *hw = rtlpriv->hw;
>
> queue_delayed_work(rtlpriv->works.rtl_wq,
> &rtlpriv->works.watchdog_wq, 0);
> --
> 2.9.0
>
Acked-by: Kees Cook <keescook@chromium.org>
Thanks for catching this! (sfr reported this too.)
-Kees
--
Kees Cook
Pixel Security
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-02 23:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-02 14:31 [PATCH] staging: rtlwifi: remove an unused variable Arnd Bergmann
2017-11-02 23:47 ` Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®