From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: "Tobin C. Harding" <me@tobin.cc>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
kernel-hardening@lists.openwall.com,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
"Theodore Ts'o" <tytso@mit.edu>,
Linus Torvalds <torvalds@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Tycho Andersen <tycho@docker.com>,
"Roberts, William C" <william.c.roberts@intel.com>,
Tejun Heo <tj@kernel.org>,
Jordan Glover <Golden_Miller83@protonmail.ch>,
Greg KH <gregkh@linuxfoundation.org>,
Petr Mladek <pmladek@suse.com>, Joe Perches <joe@perches.com>,
Ian Campbell <ijc@hellion.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <wilal.deacon@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Chris Fries <cfries@google.com>,
Dave Weinstein <olorin@google.com>,
Daniel Micay <danielmicay@gmail.com>,
Djalal Harouni <tixxdz@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V8 0/2] printk: hash addresses printed with %p
Date: Fri, 3 Nov 2017 01:04:09 +0900 [thread overview]
Message-ID: <20171102160409.GE7195@tigerII.localdomain> (raw)
In-Reply-To: <20171102101449.GG7499@eros>
On (11/02/17 21:14), Tobin C. Harding wrote:
[..]
> I can put my email address if there is not a better option.
sounds good.
> > hm... just a huge pile of if's
> >
> > if (is_vmalloc_addr(addr))
> > do_hashing(addr);
> > else if (__module_address(addr))
> > do_hashing(addr);
> > else if (is_kernel(addr) || is_kernel_inittext(addr))
> > ...
> >
> > but that's going to be really messy and "iffy".
>
> This is the only suggestion we have so far.
>
well... one more: check if we can safely dereference it. if so
it's a pointer, probably :)
if (!probe_kernel_address(addr, p))
do_hashing(addr);
just an idea.
-ss
next prev parent reply other threads:[~2017-11-02 16:04 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 2:53 Tobin C. Harding
2017-10-26 2:53 ` [PATCH V8 1/2] printk: remove tabular output for NULL pointer Tobin C. Harding
2017-10-26 4:57 ` Joe Perches
2017-10-26 6:27 ` Tobin C. Harding
2017-10-26 8:05 ` Joe Perches
2017-10-26 9:37 ` Tobin C. Harding
2017-10-26 14:47 ` Joe Perches
2017-10-26 23:57 ` Tobin C. Harding
2017-10-27 0:11 ` Joe Perches
2017-10-26 2:53 ` [PATCH V8 2/2] printk: hash addresses printed with %p Tobin C. Harding
2017-10-26 2:58 ` Tobin C. Harding
2017-10-30 21:33 ` Steven Rostedt
2017-10-30 22:41 ` Tobin C. Harding
2017-10-31 0:00 ` Steven Rostedt
2017-10-31 2:00 ` Tobin C. Harding
2017-10-26 3:11 ` Jason A. Donenfeld
2017-10-27 13:33 ` [PATCH V8 0/2] " Sergey Senozhatsky
2017-10-31 23:35 ` Tobin C. Harding
2017-11-02 8:23 ` Sergey Senozhatsky
2017-11-02 10:14 ` Tobin C. Harding
2017-11-02 13:43 ` Roberts, William C
2017-11-02 16:04 ` Sergey Senozhatsky [this message]
2017-10-30 22:03 ` Kees Cook
2017-10-30 22:33 ` Tobin C. Harding
2017-10-31 2:08 ` Joe Perches
2017-10-31 23:16 ` Tobin C. Harding
2017-10-31 23:33 ` Joe Perches
2017-11-03 5:13 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171102160409.GE7195@tigerII.localdomain \
--to=sergey.senozhatsky@gmail.com \
--cc=Golden_Miller83@protonmail.ch \
--cc=Jason@zx2c4.com \
--cc=catalin.marinas@arm.com \
--cc=cfries@google.com \
--cc=danielmicay@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ijc@hellion.org.uk \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=me@tobin.cc \
--cc=olorin@google.com \
--cc=pbonzini@redhat.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=tixxdz@gmail.com \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tycho@docker.com \
--cc=tytso@mit.edu \
--cc=wilal.deacon@arm.com \
--cc=william.c.roberts@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome