* [PATCH] x86: kvm: mmu: make kvm_mmu_clear_all_pte_masks static
@ 2017-11-03 18:52 Gimcuan Hui
2017-11-06 11:59 ` David Hildenbrand
2017-11-13 15:17 ` Paolo Bonzini
0 siblings, 2 replies; 3+ messages in thread
From: Gimcuan Hui @ 2017-11-03 18:52 UTC (permalink / raw)
To: Paolo Bonzini, Radim Krčmář,
Thomas Gleixner, Ingo Molnar, H. Peter Anvin
Cc: x86, kvm, linux-kernel, Gimcuan Hui
The kvm_mmu_clear_all_pte_masks interface is only used by kvm_mmu_module_init
locally, and does not need to be called by other module, make it static.
This patch cleans up sparse warning:
symbol 'kvm_mmu_clear_all_pte_masks' was not declared. Should it be static?
Signed-off-by: Gimcuan Hui <gimcuan@gmail.com>
---
arch/x86/kvm/mmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
index 7a69cf053711..6b247d64926e 100644
--- a/arch/x86/kvm/mmu.c
+++ b/arch/x86/kvm/mmu.c
@@ -367,7 +367,7 @@ void kvm_mmu_set_mask_ptes(u64 user_mask, u64 accessed_mask,
}
EXPORT_SYMBOL_GPL(kvm_mmu_set_mask_ptes);
-void kvm_mmu_clear_all_pte_masks(void)
+static void kvm_mmu_clear_all_pte_masks(void)
{
shadow_user_mask = 0;
shadow_accessed_mask = 0;
--
2.11.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] x86: kvm: mmu: make kvm_mmu_clear_all_pte_masks static
2017-11-03 18:52 [PATCH] x86: kvm: mmu: make kvm_mmu_clear_all_pte_masks static Gimcuan Hui
@ 2017-11-06 11:59 ` David Hildenbrand
2017-11-13 15:17 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: David Hildenbrand @ 2017-11-06 11:59 UTC (permalink / raw)
To: Gimcuan Hui, Paolo Bonzini, Radim Krčmář,
Thomas Gleixner, Ingo Molnar, H. Peter Anvin
Cc: x86, kvm, linux-kernel
On 03.11.2017 19:52, Gimcuan Hui wrote:
> The kvm_mmu_clear_all_pte_masks interface is only used by kvm_mmu_module_init
> locally, and does not need to be called by other module, make it static.
>
> This patch cleans up sparse warning:
> symbol 'kvm_mmu_clear_all_pte_masks' was not declared. Should it be static?
>
> Signed-off-by: Gimcuan Hui <gimcuan@gmail.com>
> ---
> arch/x86/kvm/mmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
> index 7a69cf053711..6b247d64926e 100644
> --- a/arch/x86/kvm/mmu.c
> +++ b/arch/x86/kvm/mmu.c
> @@ -367,7 +367,7 @@ void kvm_mmu_set_mask_ptes(u64 user_mask, u64 accessed_mask,
> }
> EXPORT_SYMBOL_GPL(kvm_mmu_set_mask_ptes);
>
> -void kvm_mmu_clear_all_pte_masks(void)
> +static void kvm_mmu_clear_all_pte_masks(void)
> {
> shadow_user_mask = 0;
> shadow_accessed_mask = 0;
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] x86: kvm: mmu: make kvm_mmu_clear_all_pte_masks static
2017-11-03 18:52 [PATCH] x86: kvm: mmu: make kvm_mmu_clear_all_pte_masks static Gimcuan Hui
2017-11-06 11:59 ` David Hildenbrand
@ 2017-11-13 15:17 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2017-11-13 15:17 UTC (permalink / raw)
To: Gimcuan Hui, Radim Krčmář,
Thomas Gleixner, Ingo Molnar, H. Peter Anvin
Cc: x86, kvm, linux-kernel
On 03/11/2017 19:52, Gimcuan Hui wrote:
> The kvm_mmu_clear_all_pte_masks interface is only used by kvm_mmu_module_init
> locally, and does not need to be called by other module, make it static.
>
> This patch cleans up sparse warning:
> symbol 'kvm_mmu_clear_all_pte_masks' was not declared. Should it be static?
>
> Signed-off-by: Gimcuan Hui <gimcuan@gmail.com>
> ---
> arch/x86/kvm/mmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
> index 7a69cf053711..6b247d64926e 100644
> --- a/arch/x86/kvm/mmu.c
> +++ b/arch/x86/kvm/mmu.c
> @@ -367,7 +367,7 @@ void kvm_mmu_set_mask_ptes(u64 user_mask, u64 accessed_mask,
> }
> EXPORT_SYMBOL_GPL(kvm_mmu_set_mask_ptes);
>
> -void kvm_mmu_clear_all_pte_masks(void)
> +static void kvm_mmu_clear_all_pte_masks(void)
> {
> shadow_user_mask = 0;
> shadow_accessed_mask = 0;
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-13 15:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-03 18:52 [PATCH] x86: kvm: mmu: make kvm_mmu_clear_all_pte_masks static Gimcuan Hui
2017-11-06 11:59 ` David Hildenbrand
2017-11-13 15:17 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®