mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: arnd@arndb.de
Cc: madalin.bucur@nxp.com, jiri@mellanox.com, jhs@mojatatu.com,
	camelia.groza@nxp.com, Linyu.Yuan@alcatel-sbell.com.cn,
	claudiu.manoil@nxp.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dpaa_eth: avoid uninitialized variable false-positive warning
Date: Sun, 05 Nov 2017 22:13:45 +0900 (KST)	[thread overview]
Message-ID: <20171105.221345.1891928990032403626.davem@davemloft.net> (raw)
In-Reply-To: <20171103125256.1829830-1-arnd@arndb.de>

From: Arnd Bergmann <arnd@arndb.de>
Date: Fri,  3 Nov 2017 13:52:24 +0100

> We can now build this driver on ARM, so I ran into a randconfig build
> warning that presumably had existed on powerpc already.
> 
> drivers/net/ethernet/freescale/dpaa/dpaa_eth.c: In function 'sg_fd_to_skb':
> drivers/net/ethernet/freescale/dpaa/dpaa_eth.c:1712:18: error: 'skb' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> 
> I'm slightly changing the logic here, to make it obvious to the
> compiler that 'skb' is always initialized.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied, thanks.

      reply	other threads:[~2017-11-05 13:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-03 12:52 Arnd Bergmann
2017-11-05 13:13 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171105.221345.1891928990032403626.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=Linyu.Yuan@alcatel-sbell.com.cn \
    --cc=arnd@arndb.de \
    --cc=camelia.groza@nxp.com \
    --cc=claudiu.manoil@nxp.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@mellanox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=madalin.bucur@nxp.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®