mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: changbin.du@intel.com
Cc: hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	yamada.masahiro@socionext.com
Subject: Re: [PATCH 2/4] x86, build: Add new paths for isolinux.bin and ldlinux.c32
Date: Sun, 5 Nov 2017 10:33:53 +0100	[thread overview]
Message-ID: <20171105093352.okrgv3623wsjwwin@gmail.com> (raw)
In-Reply-To: <1509873493-17929-3-git-send-email-changbin.du@intel.com>


* changbin.du@intel.com <changbin.du@intel.com> wrote:

> From: Changbin Du <changbin.du@intel.com>
> 
> Recently I failed to build isoimage target, because the path of isolinux.bin
> changed to /usr/xxx/ISOLINUX/isolinux.bin, as well as ldlinux.c32 which
> changed to /usr/xxx/syslinux/modules/bios/ldlinux.c32.
> 
> This patch has a improvement of the file search:
>   - Show a error message instead of silent fail.
>   - Add above new paths.

How about:

  This patch improves the file search logic:
    - Show an error message instead of failing silently
    - Add the new paths listed above.


> +		if [ $i = end -a -z "$isolinux" ] ; then
> +			echo 'Need isolinux.bin, please install syslinux/isolinux'

How about:

			echo 'Need an isolinux.bin file, please install syslinux/isolinux'

Thanks,

	Ingo

  reply	other threads:[~2017-11-05  9:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-05  9:18 [PATCH 0/4] x86, kbuild: Some improvements for fdimage/isoimage generation changbin.du
2017-11-05  9:18 ` [PATCH 1/4] x86, build: Fact out fdimage/isoimage generation commands to standalone script changbin.du
2017-11-05  9:32   ` Ingo Molnar
2017-11-06  2:58     ` Du, Changbin
2017-11-05  9:18 ` [PATCH 2/4] x86, build: Add new paths for isolinux.bin and ldlinux.c32 changbin.du
2017-11-05  9:33   ` Ingo Molnar [this message]
2017-11-06  3:00     ` Du, Changbin
2017-11-05  9:18 ` [PATCH 3/4] x86, build: Specify -input-charset=utf-8 for mkisofs changbin.du
2017-11-05  9:34   ` Ingo Molnar
2017-11-05  9:18 ` [PATCH 4/4] x86, boot: Add some generated files to the .gitignore file changbin.du
2017-11-05  9:37 ` [PATCH 0/4] x86, kbuild: Some improvements for fdimage/isoimage generation Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171105093352.okrgv3623wsjwwin@gmail.com \
    --to=mingo@kernel.org \
    --cc=changbin.du@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome