* [PATCH] drm/rockchip: add CONFIG_OF dependency for lvds
@ 2017-11-06 13:58 Arnd Bergmann
2017-11-06 15:36 ` Sean Paul
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2017-11-06 13:58 UTC (permalink / raw)
To: Mark Yao, David Airlie, Heiko Stuebner
Cc: Arnd Bergmann, Sean Paul, Guenter Roeck, Chris Zhong,
Sandy Huang, Jeffy Chen, dri-devel, linux-arm-kernel,
linux-rockchip, linux-kernel
Build-testing on randconfig kernels revealed a dependency in the
newly added lvds sub-driver:
drivers/gpu/drm/rockchip/rockchip_lvds.c: In function 'rockchip_lvds_bind':
drivers/gpu/drm/rockchip/rockchip_lvds.c:380:24: error: 'struct drm_bridge' has no member named 'of_node'
remote = lvds->bridge->of_node;
We could work around that in the code, adding a Kconfig dependency
seems easier.
Fixes: 34cc0aa25456 ("drm/rockchip: Add support for Rockchip Soc LVDS")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/rockchip/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig
index 3c70c6224bd2..0ccc76217ee4 100644
--- a/drivers/gpu/drm/rockchip/Kconfig
+++ b/drivers/gpu/drm/rockchip/Kconfig
@@ -60,7 +60,7 @@ config ROCKCHIP_INNO_HDMI
config ROCKCHIP_LVDS
bool "Rockchip LVDS support"
depends on DRM_ROCKCHIP
- depends on PINCTRL
+ depends on PINCTRL && OF
help
Choose this option to enable support for Rockchip LVDS controllers.
Rockchip rk3288 SoC has LVDS TX Controller can be used, and it
--
2.9.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] drm/rockchip: add CONFIG_OF dependency for lvds
2017-11-06 13:58 [PATCH] drm/rockchip: add CONFIG_OF dependency for lvds Arnd Bergmann
@ 2017-11-06 15:36 ` Sean Paul
0 siblings, 0 replies; 2+ messages in thread
From: Sean Paul @ 2017-11-06 15:36 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Mark Yao, David Airlie, Heiko Stuebner, Sean Paul, Guenter Roeck,
Chris Zhong, Sandy Huang, Jeffy Chen, dri-devel,
linux-arm-kernel, linux-rockchip, linux-kernel
On Mon, Nov 06, 2017 at 02:58:43PM +0100, Arnd Bergmann wrote:
> Build-testing on randconfig kernels revealed a dependency in the
> newly added lvds sub-driver:
>
> drivers/gpu/drm/rockchip/rockchip_lvds.c: In function 'rockchip_lvds_bind':
> drivers/gpu/drm/rockchip/rockchip_lvds.c:380:24: error: 'struct drm_bridge' has no member named 'of_node'
> remote = lvds->bridge->of_node;
>
> We could work around that in the code, adding a Kconfig dependency
> seems easier.
>
> Fixes: 34cc0aa25456 ("drm/rockchip: Add support for Rockchip Soc LVDS")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks for the patch Arnd, I've pushed to drm-misc-next-fixes.
Sean
> ---
> drivers/gpu/drm/rockchip/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig
> index 3c70c6224bd2..0ccc76217ee4 100644
> --- a/drivers/gpu/drm/rockchip/Kconfig
> +++ b/drivers/gpu/drm/rockchip/Kconfig
> @@ -60,7 +60,7 @@ config ROCKCHIP_INNO_HDMI
> config ROCKCHIP_LVDS
> bool "Rockchip LVDS support"
> depends on DRM_ROCKCHIP
> - depends on PINCTRL
> + depends on PINCTRL && OF
> help
> Choose this option to enable support for Rockchip LVDS controllers.
> Rockchip rk3288 SoC has LVDS TX Controller can be used, and it
> --
> 2.9.0
>
--
Sean Paul, Software Engineer, Google / Chromium OS
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-06 15:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-06 13:58 [PATCH] drm/rockchip: add CONFIG_OF dependency for lvds Arnd Bergmann
2017-11-06 15:36 ` Sean Paul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®