* [PATCH] selftests: kselftest.h: fix compilation errors
@ 2017-11-08 5:24 Lei Yang
2017-11-08 15:26 ` Shuah Khan
0 siblings, 1 reply; 2+ messages in thread
From: Lei Yang @ 2017-11-08 5:24 UTC (permalink / raw)
To: lei.yang, shuahkh, linux-kselftest, linux-kernel
In next branch, Various build failed with:
In file included from membarrier_test.c:8:0:
../kselftest.h: In function ‘ksft_print_header’:
../kselftest.h:61:3: error: expected ‘)’ before ‘printf’
printf("TAP version 13\n");
^
../kselftest.h:62:1: error: expected expression before ‘}’ token
}
^
Signed-off-by: Lei Yang <Lei.Yang@windriver.com>
---
tools/testing/selftests/kselftest.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/kselftest.h b/tools/testing/selftests/kselftest.h
index d6732ba312ef..acc98a5c3d73 100644
--- a/tools/testing/selftests/kselftest.h
+++ b/tools/testing/selftests/kselftest.h
@@ -57,7 +57,7 @@ static inline int ksft_get_error_cnt(void) { return ksft_cnt.ksft_error; }
static inline void ksft_print_header(void)
{
- if (!(getenv("KSFT_TAP_LEVEL"))
+ if (!(getenv("KSFT_TAP_LEVEL")))
printf("TAP version 13\n");
}
--
2.11.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] selftests: kselftest.h: fix compilation errors
2017-11-08 5:24 [PATCH] selftests: kselftest.h: fix compilation errors Lei Yang
@ 2017-11-08 15:26 ` Shuah Khan
0 siblings, 0 replies; 2+ messages in thread
From: Shuah Khan @ 2017-11-08 15:26 UTC (permalink / raw)
To: Lei Yang, linux-kselftest, linux-kernel, Shuah Khan
On 11/07/2017 10:24 PM, Lei Yang wrote:
> In next branch, Various build failed with:
>
> In file included from membarrier_test.c:8:0:
> ../kselftest.h: In function ‘ksft_print_header’:
> ../kselftest.h:61:3: error: expected ‘)’ before ‘printf’
> printf("TAP version 13\n");
> ^
> ../kselftest.h:62:1: error: expected expression before ‘}’ token
> }
> ^
>
> Signed-off-by: Lei Yang <Lei.Yang@windriver.com>
> ---
> tools/testing/selftests/kselftest.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/kselftest.h b/tools/testing/selftests/kselftest.h
> index d6732ba312ef..acc98a5c3d73 100644
> --- a/tools/testing/selftests/kselftest.h
> +++ b/tools/testing/selftests/kselftest.h
> @@ -57,7 +57,7 @@ static inline int ksft_get_error_cnt(void) { return ksft_cnt.ksft_error; }
>
> static inline void ksft_print_header(void)
> {
> - if (!(getenv("KSFT_TAP_LEVEL"))
> + if (!(getenv("KSFT_TAP_LEVEL")))
> printf("TAP version 13\n");
> }
>
>
Thanks for the patch. It was a mistake that the original patch
ended up in the linux-kselftest next branch. My bad. I ended up
committing the patch my mistake. It is now removed.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-08 15:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-08 5:24 [PATCH] selftests: kselftest.h: fix compilation errors Lei Yang
2017-11-08 15:26 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®