mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Haozhong Zhang <haozhong.zhang@intel.com>
To: kvm@vger.kernel.org, x86@kernel.org
Cc: linux-kernel@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
	rkrcmar@redhat.com, Xiao Guangrong <xiaoguangrong.eric@gmail.com>,
	Dan Williams <dan.j.williams@intel.com>,
	ivan.d.cuevas.escareno@intel.com, karthik.kumar@intel.com,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Olif Chapman <olif.chapman@oracle.com>,
	Mikulas Patocka <mpatocka@redhat.com>,
	Haozhong Zhang <haozhong.zhang@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Borislav Petkov <bp@suse.de>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: [PATCH v5 0/2] KVM: MMU: fix kvm_is_mmio_pfn()
Date: Wed,  8 Nov 2017 15:56:28 +0800	[thread overview]
Message-ID: <20171108075630.16991-1-haozhong.zhang@intel.com> (raw)

Some reserved pages, such as those from NVDIMM DAX devices, are not
for MMIO, and can be mapped with cached memory type for better
performance. However, the above check misconceives those pages as
MMIO.  Because KVM maps MMIO pages with UC memory type, the
performance of guest accesses to those pages would be harmed.
Therefore, we check the host memory type in addition and only treat
UC/UC- pages as MMIO.

Changes in v5:
 * Rename pat_pfn_is_uc() into pat_pfn_is_uc_or_uc_minus() to avoid
   confusion.
 * Drop converters between kvm_pfn_t and pfn_t, because they are not
   necessary. pat_pfn_is_uc_or_uc_minus() does not need flags in
   pfn_t, so we can only pass a raw unsigned long to it.

Changes in v4:
 * Mask pfn_t and kvm_pfn_t specific flags in conversion.

Changes in v3:
 * Move cache mode check to pat.c as pat_pfn_is_uc()
 * Reintroduce converters between kvm_pfn_t and pfn_t.

Changes in v2:
 * Switch to lookup_memtype() to get host memory type.
 * Rewrite the comment in KVM MMU patch.
 * Remove v1 patch 2, which is not necessary in v2.


Haozhong Zhang (2):
  x86/mm: add functions to check if a pfn is UC/UC-
  KVM: MMU: consider host cache mode in MMIO page check

 arch/x86/include/asm/pat.h |  2 ++
 arch/x86/kvm/mmu.c         | 15 ++++++++++++++-
 arch/x86/mm/pat.c          | 16 ++++++++++++++++
 3 files changed, 32 insertions(+), 1 deletion(-)

-- 
2.14.1

             reply	other threads:[~2017-11-08  7:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-08  7:56 Haozhong Zhang [this message]
2017-11-08  7:56 ` [PATCH v5 1/2] x86/mm: add a function to check if a pfn is UC/UC- Haozhong Zhang
2017-11-15 10:44   ` David Hildenbrand
2017-11-16  7:08     ` Haozhong Zhang
2017-11-15 15:17   ` Dan Williams
2017-11-16  6:13     ` Haozhong Zhang
2017-12-18 12:55   ` Paolo Bonzini
2017-12-19  2:40     ` Haozhong Zhang
2017-12-19 10:42       ` Paolo Bonzini
2017-11-08  7:56 ` [PATCH v5 2/2] KVM: MMU: consider host cache mode in MMIO page check Haozhong Zhang
2017-12-15  9:14   ` Paolo Bonzini
2017-11-08  9:19 ` [PATCH v5 0/2] KVM: MMU: fix kvm_is_mmio_pfn() Xiao Guangrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171108075630.16991-1-haozhong.zhang@intel.com \
    --to=haozhong.zhang@intel.com \
    --cc=bp@suse.de \
    --cc=dan.j.williams@intel.com \
    --cc=hpa@zytor.com \
    --cc=ivan.d.cuevas.escareno@intel.com \
    --cc=karthik.kumar@intel.com \
    --cc=konrad.wilk@oracle.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=mpatocka@redhat.com \
    --cc=olif.chapman@oracle.com \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=thomas.lendacky@amd.com \
    --cc=x86@kernel.org \
    --cc=xiaoguangrong.eric@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®