From: Haozhong Zhang <haozhong.zhang@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org, rkrcmar@redhat.com,
Xiao Guangrong <xiaoguangrong.eric@gmail.com>,
Dan Williams <dan.j.williams@intel.com>,
ivan.d.cuevas.escareno@intel.com, karthik.kumar@intel.com,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Olif Chapman <olif.chapman@oracle.com>,
Mikulas Patocka <mpatocka@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Borislav Petkov <bp@suse.de>,
Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH v5 1/2] x86/mm: add a function to check if a pfn is UC/UC-
Date: Tue, 19 Dec 2017 10:40:53 +0800 [thread overview]
Message-ID: <20171219024053.b5ckuwevnm2ydzef@hz-desktop> (raw)
In-Reply-To: <2da7d38c-8135-a722-8d93-f3d1a618b12e@redhat.com>
On 12/18/17 13:55 +0100, Paolo Bonzini wrote:
> On 08/11/2017 08:56, Haozhong Zhang wrote:
> > +bool pat_pfn_is_uc_or_uc_minus(unsigned long pfn)
> > +{
> > + enum page_cache_mode cm = lookup_memtype(PFN_PHYS(pfn));
> > +
> > + return cm == _PAGE_CACHE_MODE_UC || cm == _PAGE_CACHE_MODE_UC_MINUS;
> > +}
> > +EXPORT_SYMBOL_GPL(pat_pfn_is_uc_or_uc_minus);
> > +
>
> As discussed in the reply to v2, this should include WC too. The
> function name could become something like pat_pfn_downgraded_by_uc_mtrr.
Or shall we just expose lookup_memtype(), and keep all other logic in
KVM? The function name still looks strange somehow, and the check of
memory type makes more sense and would be easier to understand in the
context of KVM.
Haozhong
next prev parent reply other threads:[~2017-12-19 2:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 7:56 [PATCH v5 0/2] KVM: MMU: fix kvm_is_mmio_pfn() Haozhong Zhang
2017-11-08 7:56 ` [PATCH v5 1/2] x86/mm: add a function to check if a pfn is UC/UC- Haozhong Zhang
2017-11-15 10:44 ` David Hildenbrand
2017-11-16 7:08 ` Haozhong Zhang
2017-11-15 15:17 ` Dan Williams
2017-11-16 6:13 ` Haozhong Zhang
2017-12-18 12:55 ` Paolo Bonzini
2017-12-19 2:40 ` Haozhong Zhang [this message]
2017-12-19 10:42 ` Paolo Bonzini
2017-11-08 7:56 ` [PATCH v5 2/2] KVM: MMU: consider host cache mode in MMIO page check Haozhong Zhang
2017-12-15 9:14 ` Paolo Bonzini
2017-11-08 9:19 ` [PATCH v5 0/2] KVM: MMU: fix kvm_is_mmio_pfn() Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171219024053.b5ckuwevnm2ydzef@hz-desktop \
--to=haozhong.zhang@intel.com \
--cc=bp@suse.de \
--cc=dan.j.williams@intel.com \
--cc=hpa@zytor.com \
--cc=ivan.d.cuevas.escareno@intel.com \
--cc=karthik.kumar@intel.com \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mpatocka@redhat.com \
--cc=olif.chapman@oracle.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
--cc=xiaoguangrong.eric@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®