[PATCH 0/2] Clean up for tsc_init()

[PATCH 0/2] Clean up for tsc_init()

[Dou Liyang]

cyc2ns_init() and detect_art() which is invoked in tsc_init(), are 
only called during boot time. So they should be a "__init" function.

Dou Liyang (2):
  x86/tsc: Mark cyc2ns_init() __init
  x86/tsc: Mark detect_art() __init

 arch/x86/kernel/tsc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.5.5

[PATCH 1/2] x86/tsc: Mark cyc2ns_init() __init

[Dou Liyang]

This function is only called by tsc_init(), which is an __init
function, so mark it __init as well.

Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
---
 arch/x86/kernel/tsc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
index 796d96b..3e7f186 100644
--- a/arch/x86/kernel/tsc.c
+++ b/arch/x86/kernel/tsc.c
@@ -112,7 +112,7 @@ static void cyc2ns_data_init(struct cyc2ns_data *data)
 	data->cyc2ns_offset = 0;
 }
 
-static void cyc2ns_init(int cpu)
+static void __init cyc2ns_init(int cpu)
 {
 	struct cyc2ns *c2n = &per_cpu(cyc2ns, cpu);
 
-- 
2.5.5

[PATCH 2/2] x86/tsc: Mark detect_art() __init

[Dou Liyang]

This function is only called by tsc_init(), which is an __init
function, so mark it __init as well.

Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
---
 arch/x86/kernel/tsc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
index 3e7f186..9b29f39 100644
--- a/arch/x86/kernel/tsc.c
+++ b/arch/x86/kernel/tsc.c
@@ -959,7 +959,7 @@ core_initcall(cpufreq_register_tsc_scaling);
 /*
  * If ART is present detect the numerator:denominator to convert to TSC
  */
-static void detect_art(void)
+static void __init detect_art(void)
 {
 	unsigned int unused[2];
 
-- 
2.5.5

Re: [PATCH 0/2] Clean up for tsc_init()

[Ingo Molnar]

* Dou Liyang <douly.fnst@cn.fujitsu.com> wrote:

> cyc2ns_init() and detect_art() which is invoked in tsc_init(), are 
> only called during boot time. So they should be a "__init" function.
> 
> Dou Liyang (2):
>   x86/tsc: Mark cyc2ns_init() __init
>   x86/tsc: Mark detect_art() __init
> 
>  arch/x86/kernel/tsc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

This should really be a single patch, but other than that:

Reviewed-by: Ingo Molnar <mingo@kernel.org>

Thanks,

	Ingo

Re: [PATCH 0/2] Clean up for tsc_init()

[Dou Liyang]

Hi Ingo,

At 11/08/2017 05:42 PM, Ingo Molnar wrote:
>
> * Dou Liyang <douly.fnst@cn.fujitsu.com> wrote:
>
>> cyc2ns_init() and detect_art() which is invoked in tsc_init(), are
>> only called during boot time. So they should be a "__init" function.
>>
>> Dou Liyang (2):
>>   x86/tsc: Mark cyc2ns_init() __init
>>   x86/tsc: Mark detect_art() __init
>>
>>  arch/x86/kernel/tsc.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> This should really be a single patch, but other than that:
>
> Reviewed-by: Ingo Molnar <mingo@kernel.org>
>

Thank you, Indeed, I will merge them together.

Thanks,
	dou.