* [PATCH] ovl: fix null pointer dereference on ofs allocation failure.
@ 2017-11-09 17:47 Colin King
2017-11-10 8:54 ` Miklos Szeredi
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-11-09 17:47 UTC (permalink / raw)
To: Miklos Szeredi, linux-unionfs; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The current error exit path when ofs fails to allocate jumps
to clean-up code that calls ovl_free_fs resulting in a null pointer
dereference on the null ovl pointer. Fix this by simply returning
with the -ENOMEM status in err.
Detected by CoverityScan, CID#1461284 ("Dereference after null check")
Fixes: 4f3bf9de9eac ("ovl: factor out ovl_free_fs() helper")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
fs/overlayfs/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
index 708afec913ac..8258a194695b 100644
--- a/fs/overlayfs/super.c
+++ b/fs/overlayfs/super.c
@@ -1154,7 +1154,7 @@ static int ovl_fill_super(struct super_block *sb, void *data, int silent)
err = -ENOMEM;
ofs = kzalloc(sizeof(struct ovl_fs), GFP_KERNEL);
if (!ofs)
- goto out_err;
+ return err;
ofs->creator_cred = cred = prepare_creds();
if (!cred)
--
2.14.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ovl: fix null pointer dereference on ofs allocation failure.
2017-11-09 17:47 [PATCH] ovl: fix null pointer dereference on ofs allocation failure Colin King
@ 2017-11-10 8:54 ` Miklos Szeredi
0 siblings, 0 replies; 2+ messages in thread
From: Miklos Szeredi @ 2017-11-10 8:54 UTC (permalink / raw)
To: Colin King; +Cc: overlayfs, kernel-janitors, lkml
On Thu, Nov 9, 2017 at 6:47 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The current error exit path when ofs fails to allocate jumps
> to clean-up code that calls ovl_free_fs resulting in a null pointer
> dereference on the null ovl pointer. Fix this by simply returning
> with the -ENOMEM status in err.
>
> Detected by CoverityScan, CID#1461284 ("Dereference after null check")
Thanks, fixed.
Miklos
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-10 8:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-09 17:47 [PATCH] ovl: fix null pointer dereference on ofs allocation failure Colin King
2017-11-10 8:54 ` Miklos Szeredi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®