From: Jan Kara <jack@suse.cz>
To: Chao Yu <yuchao0@huawei.com>
Cc: jack@suse.com, linux-kernel@vger.kernel.org, chao@kernel.org
Subject: Re: [PATCH] quota: be aware of error from dquot_initialize
Date: Mon, 13 Nov 2017 10:18:35 +0100 [thread overview]
Message-ID: <20171113091835.GA24824@quack2.suse.cz> (raw)
In-Reply-To: <20171113033148.25464-1-yuchao0@huawei.com>
On Mon 13-11-17 11:31:48, Chao Yu wrote:
> Commit 6184fc0b8dd7 ("quota: Propagate error from ->acquire_dquot()")
> missed to handle error from dquot_initialize in dquot_file_open, fix it.
>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
Good spotting. I've added the patch to my tree.
Honza
> ---
> fs/quota/dquot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c
> index 50b0556a124f..80002c094647 100644
> --- a/fs/quota/dquot.c
> +++ b/fs/quota/dquot.c
> @@ -2133,7 +2133,7 @@ int dquot_file_open(struct inode *inode, struct file *file)
>
> error = generic_file_open(inode, file);
> if (!error && (file->f_mode & FMODE_WRITE))
> - dquot_initialize(inode);
> + error = dquot_initialize(inode);
> return error;
> }
> EXPORT_SYMBOL(dquot_file_open);
> --
> 2.15.0.55.gc2ece9dc4de6
>
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2017-11-13 9:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-13 3:31 Chao Yu
2017-11-13 9:18 ` Jan Kara [this message]
2017-11-14 3:43 ` Chao Yu
2017-11-14 9:24 ` Jan Kara
2017-11-17 2:10 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171113091835.GA24824@quack2.suse.cz \
--to=jack@suse.cz \
--cc=chao@kernel.org \
--cc=jack@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®