mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: alexander.levin@verizon.com
To: Alexander Sverdlin <alexander.sverdlin@gmail.com>
Cc: Mengting Zhang <zhangmengting@huawei.com>,
	"ben@decadent.org.uk" <ben@decadent.org.uk>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"huawei.libin@huawei.com" <huawei.libin@huawei.com>
Subject: Re: [PATCH] lockdep: Add missing declaration of 'pr_cont()'
Date: Mon, 13 Nov 2017 15:09:17 +0000	[thread overview]
Message-ID: <20171113150914.kpgtalzgssx44do3@sasha-lappy> (raw)
In-Reply-To: <1510071007.4450.13.camel@Nokia-N900>

On Tue, Nov 07, 2017 at 05:10:07PM +0100, Alexander Sverdlin wrote:
>Hello!
>
>On Tue Nov   7 03:24:20 2017 Mengting Zhang <zhangmengting@huawei.com> wrote:
>> An annoying compile warning due to missing declaration is shown below:
>> In file included from lockdep.c:27:0:
>> ../../../kernel/locking/lockdep.c: In function
>> 'print_unlock_imbalance_bug' : ../../../kernel/locking/lockdep.c:3544:2:
>> warning: implicit declaration of function 'pr_cont'
>> [-Wimplicit-function-declaration]   pr_cont(") at:\n");   ^
>> Adding the declaration of 'pr_cont' fixes the problem.
>>
>> Signed-off-by: Mengting Zhang <zhangmengting@huawei.com>
>
>Your commit brought my attention to the fact that commit 681fbec881 brought a regression, rendering 20fb654ae fix ineffective.
>
>But this is not related to your change, which I believe is correct:
>Reviewed-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>

Thanks! Queued up.

-- 

Thanks,
Sasha

      reply	other threads:[~2017-11-13 15:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-07  2:24 Mengting Zhang
2017-11-07 16:10 ` Alexander Sverdlin
2017-11-13 15:09   ` alexander.levin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171113150914.kpgtalzgssx44do3@sasha-lappy \
    --to=alexander.levin@verizon.com \
    --cc=alexander.sverdlin@gmail.com \
    --cc=ben@decadent.org.uk \
    --cc=huawei.libin@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zhangmengting@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®