From: Dan Carpenter <dan.carpenter@oracle.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: alsa-devel@alsa-project.org, Bhumika Goyal <bhumirks@gmail.com>,
Fabian Frederick <fabf@skynet.be>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Takashi Sakamoto <o-takashi@sakamocchi.jp>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/4] ALSA: cs46xx: Adjust 33 function calls together with a variable assignment
Date: Mon, 13 Nov 2017 21:30:29 +0300 [thread overview]
Message-ID: <20171113183029.sudeyhgh7v6buukx@mwanda> (raw)
In-Reply-To: <5da69abe-0bcd-e2c3-cb11-04b44b4f8bd2@users.sourceforge.net>
On Mon, Nov 13, 2017 at 07:22:30PM +0100, SF Markus Elfring wrote:
> -
> - if ( (cpcm->pcm_channel = cs46xx_dsp_create_pcm_channel (chip, sample_rate, cpcm,
> - cpcm->hw_buf.addr,
> - cpcm->pcm_channel_id)) == NULL) {
> + cpcm
> + ->pcm_channel = cs46xx_dsp_create_pcm_channel(chip,
^^^^^^^^^^^^^
Please don't break it up like this
> + sample_rate,
> + cpcm,
> + cpcm->hw_buf.addr,
> + cpcm
> + ->pcm_channel_id);
^^^^^^^^^^^^^^^^
or this. It's better to go over 80 characters than to do that.
regards,
dan carpenter
next prev parent reply other threads:[~2017-11-13 18:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-13 18:21 [PATCH 0/4] ALSA: cs46xx: Adjustments for some function implementations SF Markus Elfring
2017-11-13 18:22 ` [PATCH 1/4] ALSA: cs46xx: Adjust 33 function calls together with a variable assignment SF Markus Elfring
2017-11-13 18:30 ` Dan Carpenter [this message]
2017-11-13 18:23 ` [PATCH 2/4] ALSA: cs46xx: Use common error handling code in two functions SF Markus Elfring
2017-11-13 18:24 ` [PATCH 3/4] ALSA: cs46xx: Improve a size determination in cs46xx_dsp_proc_register_scb_desc() SF Markus Elfring
2017-11-13 18:25 ` [PATCH 4/4] ALSA: cs46xx: Adjust 35 checks for null pointers SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171113183029.sudeyhgh7v6buukx@mwanda \
--to=dan.carpenter@oracle.com \
--cc=alsa-devel@alsa-project.org \
--cc=bhumirks@gmail.com \
--cc=elfring@users.sourceforge.net \
--cc=fabf@skynet.be \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=o-takashi@sakamocchi.jp \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®