From: Peter Zijlstra <peterz@infradead.org>
To: Wanpeng Li <kernellwp@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
kvm <kvm@vger.kernel.org>, Paolo Bonzini <pbonzini@redhat.com>,
Radim Kr??m???? <rkrcmar@redhat.com>,
Wanpeng Li <wanpeng.li@hotmail.com>
Subject: Re: [PATCH v4 2/4] KVM: X86: Add paravirt remote TLB flush
Date: Tue, 14 Nov 2017 08:35:39 +0100 [thread overview]
Message-ID: <20171114073539.jtorcwygspaqbpjb@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <CANRm+CxCMNht4JMC4e5qhQVOjj3z2P8ZZbc1fTzX=v_a-HDD4w@mail.gmail.com>
On Tue, Nov 14, 2017 at 02:10:16PM +0800, Wanpeng Li wrote:
> 2017-11-13 21:02 GMT+08:00 Peter Zijlstra <peterz@infradead.org>:
> > That can be written like:
> >
> > do {
> > if (state & KVM_VCPU_PREEMPTED)
> > new_state = state | KVM_VCPU_SHOULD_FLUSH;
> > else
> > new_state = state | KVM_VCPU_IPI_PENDING;
> > } while (!try_cmpxchg(&src->preempted, state, new_state);
> >
> > if (new_state & KVM_VCPU_IPI_PENDING)
>
> Should be new_state & KVM_VCPU_SHOULD_FLUSH I think.
Quite so indeed.
next prev parent reply other threads:[~2017-11-14 7:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-13 0:33 [PATCH v4 0/4] KVM: X86: Paravirt " Wanpeng Li
2017-11-13 0:33 ` [PATCH v4 1/4] KVM: X86: Add vCPU running/preempted state Wanpeng Li
2017-11-14 16:45 ` David Hildenbrand
2017-11-14 17:03 ` Peter Zijlstra
2017-11-14 17:04 ` Paolo Bonzini
2017-11-13 0:33 ` [PATCH v4 2/4] KVM: X86: Add paravirt remote TLB flush Wanpeng Li
2017-11-13 7:59 ` Peter Zijlstra
2017-11-13 8:12 ` Wanpeng Li
2017-11-13 8:04 ` Peter Zijlstra
2017-11-13 8:26 ` Wanpeng Li
2017-11-13 10:46 ` Peter Zijlstra
2017-11-13 13:02 ` Peter Zijlstra
2017-11-14 6:10 ` Wanpeng Li
2017-11-14 7:35 ` Peter Zijlstra [this message]
2017-11-14 6:28 ` Wanpeng Li
2017-11-14 7:56 ` Peter Zijlstra
2017-11-13 0:33 ` [PATCH v4 3/4] KVM: X86: introduce invalidate_gpa argument to tlb flush Wanpeng Li
2017-11-13 0:33 ` [PATCH v4 4/4] KVM: X86: Add flush_on_enter before guest enter Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171114073539.jtorcwygspaqbpjb@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=kernellwp@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=wanpeng.li@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®