From: alexander.levin@verizon.com
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Cc: Pan Bian <bianpan2016@163.com>, David Sterba <dsterba@suse.com>,
alexander.levin@verizon.com
Subject: [PATCH AUTOSEL for 3.18 13/16] btrfs: return the actual error value from from btrfs_uuid_tree_iterate
Date: Wed, 15 Nov 2017 02:46:16 +0000 [thread overview]
Message-ID: <20171115024607.6064-13-alexander.levin@verizon.com> (raw)
In-Reply-To: <20171115024607.6064-1-alexander.levin@verizon.com>
From: Pan Bian <bianpan2016@163.com>
[ Upstream commit 73ba39ab9307340dc98ec3622891314bbc09cc2e ]
In function btrfs_uuid_tree_iterate(), errno is assigned to variable ret
on errors. However, it directly returns 0. It may be better to return
ret. This patch also removes the warning, because the caller already
prints a warning.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188731
Signed-off-by: Pan Bian <bianpan2016@163.com>
Reviewed-by: Omar Sandoval <osandov@fb.com>
[ edited subject ]
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
---
fs/btrfs/uuid-tree.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/fs/btrfs/uuid-tree.c b/fs/btrfs/uuid-tree.c
index 778282944530..837a9a8d579e 100644
--- a/fs/btrfs/uuid-tree.c
+++ b/fs/btrfs/uuid-tree.c
@@ -348,7 +348,5 @@ int btrfs_uuid_tree_iterate(struct btrfs_fs_info *fs_info,
out:
btrfs_free_path(path);
- if (ret)
- btrfs_warn(fs_info, "btrfs_uuid_tree_iterate failed %d", ret);
- return 0;
+ return ret;
}
--
2.11.0
next prev parent reply other threads:[~2017-11-15 2:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 2:46 [PATCH AUTOSEL for 3.18 01/16] ACPICA: Resources: Not a valid resource if buffer length too long alexander.levin
2017-11-15 2:46 ` [PATCH AUTOSEL for 3.18 02/16] RDS: RDMA: return appropriate error on rdma map failures alexander.levin
2017-11-15 2:46 ` [PATCH AUTOSEL for 3.18 03/16] PCI: Apply _HPX settings only to relevant devices alexander.levin
2017-11-15 2:46 ` [PATCH AUTOSEL for 3.18 06/16] drm/armada: Fix compile fail alexander.levin
2017-11-15 2:46 ` [PATCH AUTOSEL for 3.18 04/16] net: 3com: typhoon: typhoon_init_one: make return values more specific alexander.levin
2017-11-15 2:46 ` [PATCH AUTOSEL for 3.18 07/16] ALSA: hda - Apply ALC269_FIXUP_NO_SHUTUP on HDA_FIXUP_ACT_PROBE alexander.levin
2017-11-15 2:46 ` [PATCH AUTOSEL for 3.18 05/16] net: 3com: typhoon: typhoon_init_one: fix incorrect return values alexander.levin
2017-11-15 2:46 ` [PATCH AUTOSEL for 3.18 10/16] staging: iio: cdc: fix improper return value alexander.levin
2017-11-15 2:46 ` [PATCH AUTOSEL for 3.18 09/16] mac80211: Suppress NEW_PEER_CANDIDATE event if no room alexander.levin
2017-11-15 2:46 ` [PATCH AUTOSEL for 3.18 08/16] mac80211: Remove invalid flag operations in mesh TSF synchronization alexander.levin
2017-11-15 2:46 ` [PATCH AUTOSEL for 3.18 12/16] netfilter: nf_tables: fix oob access alexander.levin
2017-11-15 2:46 ` [PATCH AUTOSEL for 3.18 11/16] netfilter: nft_queue: use raw_smp_processor_id() alexander.levin
2017-11-15 2:46 ` [PATCH AUTOSEL for 3.18 14/16] ASoC: wm_adsp: Don't overrun firmware file buffer when reading region data alexander.levin
2017-11-15 2:46 ` alexander.levin [this message]
2017-11-15 2:46 ` [PATCH AUTOSEL for 3.18 15/16] s390/kbuild: enable modversions for symbols exported from asm alexander.levin
2017-11-15 2:46 ` [PATCH AUTOSEL for 3.18 16/16] xen: xenbus driver must not accept invalid transaction ids alexander.levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171115024607.6064-13-alexander.levin@verizon.com \
--to=alexander.levin@verizon.com \
--cc=bianpan2016@163.com \
--cc=dsterba@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®