From: Michal Hocko <mhocko@kernel.org>
To: Fan Du <fan.du@intel.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] memory hotplug: fix comments when add section
Date: Wed, 15 Nov 2017 10:18:55 +0100 [thread overview]
Message-ID: <20171115091855.tkqbex2ow3m5jpdk@dhcp22.suse.cz> (raw)
In-Reply-To: <1510735205-22540-1-git-send-email-fan.du@intel.com>
On Wed 15-11-17 16:40:05, Fan Du wrote:
> Here, pfn_to_node should be page_to_nid.
>
> Signed-off-by: Fan Du <fan.du@intel.com>
Yes, it is a typo. And the one worth fixing because this will make git grep
great again
Acked-by: Michal Hocko <mhocko@suse.com>
> ---
> mm/memory_hotplug.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index d4b5f29..c3c1c57 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -265,7 +265,7 @@ static int __meminit __add_section(int nid, unsigned long phys_start_pfn,
> /*
> * Make all the pages reserved so that nobody will stumble over half
> * initialized state.
> - * FIXME: We also have to associate it with a node because pfn_to_node
> + * FIXME: We also have to associate it with a node because page_to_nid
> * relies on having page with the proper node.
> */
> for (i = 0; i < PAGES_PER_SECTION; i++) {
> --
> 1.8.3.1
--
Michal Hocko
SUSE Labs
prev parent reply other threads:[~2017-11-15 9:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 8:40 Fan Du
2017-11-15 9:18 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171115091855.tkqbex2ow3m5jpdk@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=fan.du@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®