* [PATCH] drm: mali-dp: Disable planes when their CRTC gets disabled.
@ 2017-11-01 14:13 Liviu Dudau
2017-11-15 19:25 ` Gustavo Padovan
0 siblings, 1 reply; 3+ messages in thread
From: Liviu Dudau @ 2017-11-01 14:13 UTC (permalink / raw)
To: Brian Starkey
Cc: Mali DP Maintainers, Daniel Vetter, David Airlie, DRI-devel,
LKML, Liviu Dudau
Make sure only the planes on the active CRTCs get committed and
that all planes on the disabled CRTCs get turned off.
Reviewed-by: Brian Starkey <brian.starkey@arm.com>
Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
---
drivers/gpu/drm/arm/malidp_crtc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/arm/malidp_crtc.c b/drivers/gpu/drm/arm/malidp_crtc.c
index 153a496706262..904fff80917ba 100644
--- a/drivers/gpu/drm/arm/malidp_crtc.c
+++ b/drivers/gpu/drm/arm/malidp_crtc.c
@@ -77,6 +77,9 @@ static void malidp_crtc_atomic_disable(struct drm_crtc *crtc,
struct malidp_hw_device *hwdev = malidp->dev;
int err;
+ /* always disable planes on the CRTC that is being turned off */
+ drm_atomic_helper_disable_planes_on_crtc(old_state, false);
+
drm_crtc_vblank_off(crtc);
hwdev->hw->enter_config_mode(hwdev);
--
2.14.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm: mali-dp: Disable planes when their CRTC gets disabled.
2017-11-01 14:13 [PATCH] drm: mali-dp: Disable planes when their CRTC gets disabled Liviu Dudau
@ 2017-11-15 19:25 ` Gustavo Padovan
2017-11-15 22:35 ` Liviu Dudau
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo Padovan @ 2017-11-15 19:25 UTC (permalink / raw)
To: Liviu Dudau
Cc: Brian Starkey, David Airlie, LKML, DRI-devel,
Mali DP Maintainers, Daniel Vetter
Hi Liviu,
2017-11-01 Liviu Dudau <Liviu.Dudau@arm.com>:
> Make sure only the planes on the active CRTCs get committed and
> that all planes on the disabled CRTCs get turned off.
>
> Reviewed-by: Brian Starkey <brian.starkey@arm.com>
> Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
> ---
> drivers/gpu/drm/arm/malidp_crtc.c | 3 +++
> 1 file changed, 3 insertions(+)
Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.com>
Gustavo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm: mali-dp: Disable planes when their CRTC gets disabled.
2017-11-15 19:25 ` Gustavo Padovan
@ 2017-11-15 22:35 ` Liviu Dudau
0 siblings, 0 replies; 3+ messages in thread
From: Liviu Dudau @ 2017-11-15 22:35 UTC (permalink / raw)
To: Gustavo Padovan
Cc: Brian Starkey, David Airlie, LKML, DRI-devel,
Mali DP Maintainers, Daniel Vetter
On Wed, Nov 15, 2017 at 05:25:02PM -0200, Gustavo Padovan wrote:
> Hi Liviu,
Hi Gustavo,
>
> 2017-11-01 Liviu Dudau <Liviu.Dudau@arm.com>:
>
> > Make sure only the planes on the active CRTCs get committed and
> > that all planes on the disabled CRTCs get turned off.
> >
> > Reviewed-by: Brian Starkey <brian.starkey@arm.com>
> > Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
> > ---
> > drivers/gpu/drm/arm/malidp_crtc.c | 3 +++
> > 1 file changed, 3 insertions(+)
>
> Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.com>
Thanks for reviewing both patches!
Best regards,
Liviu
>
> Gustavo
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-15 22:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-01 14:13 [PATCH] drm: mali-dp: Disable planes when their CRTC gets disabled Liviu Dudau
2017-11-15 19:25 ` Gustavo Padovan
2017-11-15 22:35 ` Liviu Dudau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome