From: Francois Romieu <romieu@fr.zoreil.com>
To: David Miller <davem@davemloft.net>
Cc: kai.heng.feng@canonical.com, nic_swsd@realtek.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
hayeswang@realtek.com, jrg.otte@gmail.com
Subject: Re: [PATCH 1/2] r8169: reinstate ALDPS for power saving
Date: Thu, 16 Nov 2017 00:33:43 +0100 [thread overview]
Message-ID: <20171115233343.GA28812@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <20171115.195306.1005850318419905294.davem@davemloft.net>
David Miller <davem@davemloft.net> :
[...]
> The amount of coverage this change is going to get is very small as
> well, meaning an even greater chance of regressions.
Yes.
> Therefore the only acceptable way to handle this is to have
> a white-list, specific chips that have been explicitly tested
> and are known to work with this feature, rather than the other
> way around.
>
> Furthermore, you're not even checking the chip version, you're
> checking instead whether the firmware is loaded or not. That
> doesn't seem like a safe way to guard this at all.
Actually the chip specific xyz_hw_phy_config methods call the relevant
aldps enabling helper _but_ the 8168evl dedicated xyz_hw_phy_config
doesn't. The firmware loaded check is just a distraction for the
busy reviewer.
--
Ueimor
next prev parent reply other threads:[~2017-11-15 23:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 9:00 Kai-Heng Feng
2017-11-15 9:00 ` [PATCH 2/2] r8169: reinstate internal ASPM and clock request settings Kai-Heng Feng
2017-11-15 10:53 ` [PATCH 1/2] r8169: reinstate ALDPS for power saving David Miller
2017-11-15 23:33 ` Francois Romieu [this message]
2017-11-16 4:29 ` Kai Heng Feng
2018-03-22 10:19 ` Kai-Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171115233343.GA28812@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=davem@davemloft.net \
--cc=hayeswang@realtek.com \
--cc=jrg.otte@gmail.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®