mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Megha Dey <megha.dey@linux.intel.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com,
	hpa@zytor.com, andriy.shevchenko@linux.intel.com,
	kstewart@linuxfoundation.org, yu-cheng.yu@intel.com,
	len.brown@intel.com, gregkh@linuxfoundation.org, acme@kernel.org,
	alexander.shishkin@linux.intel.com, jolsa@redhat.com,
	namhyung@kernel.org, vikas.shivappa@linux.intel.com,
	pombredanne@nexb.com, me@kylehuey.com, bp@suse.de,
	grzegorz.andrejczuk@intel.com, tony.luck@intel.com,
	corbet@lwn.net, ravi.v.shankar@intel.com, megha.dey@intel.com
Subject: Re: [PATCH V2 2/3] perf/x86/intel/bm.c: Add Intel Branch Monitoring support
Date: Mon, 20 Nov 2017 12:57:14 +0100	[thread overview]
Message-ID: <20171120115714.hden247iet4bf2t5@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <1510970046-25387-3-git-send-email-megha.dey@linux.intel.com>

On Fri, Nov 17, 2017 at 05:54:05PM -0800, Megha Dey wrote:
> +	mutex_lock(&bm_counter_mutex);
> +	for (i = 0; i < BM_MAX_COUNTERS; i++) {
> +		if (bm_counter_owner[i] == NULL) {
> +			counter_to_use = i;
> +			bm_counter_owner[i] = event;
> +			break;
> +		}
> +	}
> +	mutex_unlock(&bm_counter_mutex);
> +
> +	if (counter_to_use == -1)
> +		return -EBUSY;

> +static struct pmu intel_bm_pmu = {
> +	.task_ctx_nr     = perf_sw_context,
> +	.attr_groups     = intel_bm_attr_groups,
> +	.event_init      = intel_bm_event_init,
> +	.add             = intel_bm_event_add,
> +	.del             = intel_bm_event_del,
> +};

Still horrid.. still no.

  reply	other threads:[~2017-11-20 11:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-18  1:54 [PATCH V2 0/3] perf/x86/intel: Add " Megha Dey
2017-11-18  1:54 ` [PATCH V2 1/3] x86/cpu/intel: Add Cannonlake to Intel family Megha Dey
2017-11-18  1:54 ` [PATCH V2 2/3] perf/x86/intel/bm.c: Add Intel Branch Monitoring support Megha Dey
2017-11-20 11:57   ` Peter Zijlstra [this message]
2017-12-12 21:10     ` Megha Dey
2017-12-12 22:32       ` Peter Zijlstra
2017-12-12 23:08         ` Megha Dey
2017-12-13  7:21           ` Peter Zijlstra
2017-12-20 21:23             ` Megha Dey
2018-04-04 21:33               ` Megha Dey
2017-11-20 14:10   ` Jiri Olsa
2017-12-12 21:03     ` Megha Dey
2017-11-18  1:54 ` [PATCH V2 3/3] x86, bm: Add documentation on Intel Branch Monitoring Megha Dey
2017-11-20 14:07   ` Jiri Olsa
2017-12-12 21:05     ` Megha Dey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171120115714.hden247iet4bf2t5@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bp@suse.de \
    --cc=corbet@lwn.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=grzegorz.andrejczuk@intel.com \
    --cc=hpa@zytor.com \
    --cc=jolsa@redhat.com \
    --cc=kstewart@linuxfoundation.org \
    --cc=len.brown@intel.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=me@kylehuey.com \
    --cc=megha.dey@intel.com \
    --cc=megha.dey@linux.intel.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=pombredanne@nexb.com \
    --cc=ravi.v.shankar@intel.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=vikas.shivappa@linux.intel.com \
    --cc=x86@kernel.org \
    --cc=yu-cheng.yu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®