From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Jim Davis <jim.epost@gmail.com>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
Knut Omang <knut.omang@oracle.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Michal Marek <mmarek@suse.com>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Subject: Re: [PATCH 2/7] kbuild: Add P= command line flag to run checkpatch
Date: Mon, 20 Nov 2017 21:08:31 +0100 [thread overview]
Message-ID: <20171120200827.726yhebihjhrhted@ltop.local> (raw)
In-Reply-To: <CA+r1ZhgPUJ_WtCM=RgiPSrSvGrp7FMni2db6S9am5-LN_vhRdg@mail.gmail.com>
On Mon, Nov 20, 2017 at 12:48:35PM -0700, Jim Davis wrote:
>
> I'd be nice if people could just specify CHECK and CHECKFLAGS to run
> their favorite checker, but currently CHECKFLAGS seems hardwired for
> running sparse. So something liike
>
> make C=1 CHECK="scripts/checkpatch.pl" CHECKFLAGS="--quiet --file"
>
> fails when checkpatch is passed lots of arguments like -D__linux__
> -Dlinux -D__STDC__ . A little shell wrapper to grab the last argument
> in that long list is a workaround, but perhaps CHECKFLAGS should be
> made less sparse-specific?
It should be noted though that CHECKFLAGS contains very very few
sparse specific things. It's mainly flags for the compiler
coming from KBUILD_CFLAGS (which of course, sparse needs to
do its job properly).
-- Luc Van Oostenryck
next prev parent reply other threads:[~2017-11-20 20:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 17:01 [PATCH 0/7] Support for automatic checkpatch running in the kernel Knut Omang
2017-11-16 17:01 ` [PATCH 1/7] checkpatch: Implement new --ignore-cfg parameter Knut Omang
2017-11-16 17:09 ` Joe Perches
2017-11-16 17:43 ` Knut Omang
2017-11-16 17:01 ` [PATCH 2/7] kbuild: Add P= command line flag to run checkpatch Knut Omang
2017-11-20 16:18 ` Masahiro Yamada
2017-11-20 19:48 ` Jim Davis
2017-11-20 20:08 ` Luc Van Oostenryck [this message]
2017-11-20 21:10 ` Knut Omang
2017-11-20 21:22 ` Luc Van Oostenryck
2017-11-21 0:00 ` Jim Davis
2017-11-21 8:10 ` Knut Omang
2017-11-21 19:48 ` Jim Davis
2017-11-21 20:03 ` Joe Perches
2017-11-20 21:04 ` Knut Omang
2017-11-16 17:01 ` [PATCH 3/7] checkpatch: Add a few convenience options to disable/modify features Knut Omang
2017-11-16 17:01 ` [PATCH 4/7] Documentation: Add documentation for the new P= Makefile option Knut Omang
2017-11-16 17:01 ` [PATCH 5/7] checkpatch: Improve --fix-inplace for TABSTOP Knut Omang
2017-11-16 17:01 ` [PATCH 6/7] checkpatch: Make --ignore-cfg look recursively for the file Knut Omang
2017-11-16 17:01 ` [PATCH 7/7] Documentation: Update checkpatch --ignore-cfg description Knut Omang
2017-11-16 22:57 ` [PATCH 0/7] Support for automatic checkpatch running in the kernel Kees Cook
2017-11-17 4:47 ` Knut Omang
2017-11-17 9:08 ` Knut Omang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171120200827.726yhebihjhrhted@ltop.local \
--to=luc.vanoostenryck@gmail.com \
--cc=jim.epost@gmail.com \
--cc=knut.omang@oracle.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®