mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eudean Sun <eudean@arista.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: cp2112: Fix I2C_BLOCK_DATA transactions
Date: Tue, 21 Nov 2017 10:40:12 -0800	[thread overview]
Message-ID: <20171121184012.GA6776@mail.arista.com> (raw)
In-Reply-To: <nycvar.YFH.7.76.1711211744250.11505@cbobk.fhfr.pm>

On Tue, Nov 21, 2017 at 05:45:32PM +0100, Jiri Kosina wrote:
> On Tue, 21 Nov 2017, Jiri Kosina wrote:
> 
> > > The existing driver erroneously treats I2C_BLOCK_DATA and BLOCK_DATA
> > > commands the same. Fix the logic for I2C_BLOCK_DATA reads and writes.
> > 
> > Addin David, the original author of the driver (and the code in question 
> > as well) to CC.
> 
> Alright, that address bounces.
> 
> In that case -- could you please be a little bit more specific in the 
> changelog? Namely: what are the observable effects of this bug (did you 
> find it by code inspection or have you seen it triggering) and why this is 
> a proper fix for that bug.

Thanks for the feedback Jiri, I will send out a new patch shortly with more detail in the changelog.

      reply	other threads:[~2017-11-21 18:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-14  0:03 Eudean Sun
2017-11-21 16:42 ` Jiri Kosina
2017-11-21 16:45   ` Jiri Kosina
2017-11-21 18:40     ` Eudean Sun [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171121184012.GA6776@mail.arista.com \
    --to=eudean@arista.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome