From: Aleksey Makarov <aleksey.makarov@auriga.com>
To: <netdev@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>,
"Goutham, Sunil" <Sunil.Goutham@cavium.com>,
Robert Richter <rric@kernel.org>,
"Florian Westphal" <fw@strlen.de>,
Aleksey Makarov <aleksey.makarov@cavium.com>,
Sunil Goutham <sgoutham@cavium.com>,
Aleksey Makarov <aleksey.makarov@auriga.com>,
<linux-arm-kernel@lists.infradead.org>
Subject: [PATCH net] net: thunderx: Fix TCP/UDP checksum offload for IPv6 pkts
Date: Wed, 22 Nov 2017 15:37:25 +0300 [thread overview]
Message-ID: <20171122123727.23580-1-aleksey.makarov@auriga.com> (raw)
From: Sunil Goutham <sgoutham@cavium.com>
This fixes a previous patch which missed some changes
and due to which L3 checksum offload was getting enabled
for IPv6 pkts. And HW is dropping these pkts as it assumes
the pkt is IPv4 when IP csum offload is set in the SQ
descriptor.
Fixes: bbbb494fd005 ("net: thunderx: Enable TSO and checksum offloads for ipv6")
Signed-off-by: Sunil Goutham <sgoutham@cavium.com>
Signed-off-by: Aleksey Makarov <aleksey.makarov@auriga.com>
---
drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/cavium/thunder/nicvf_queues.c b/drivers/net/ethernet/cavium/thunder/nicvf_queues.c
index d4496e9afcdf..184d5bdbe7e0 100644
--- a/drivers/net/ethernet/cavium/thunder/nicvf_queues.c
+++ b/drivers/net/ethernet/cavium/thunder/nicvf_queues.c
@@ -1355,10 +1355,11 @@ nicvf_sq_add_hdr_subdesc(struct nicvf *nic, struct snd_queue *sq, int qentry,
/* Offload checksum calculation to HW */
if (skb->ip_summed == CHECKSUM_PARTIAL) {
- hdr->csum_l3 = 1; /* Enable IP csum calculation */
hdr->l3_offset = skb_network_offset(skb);
hdr->l4_offset = skb_transport_offset(skb);
+ /* Enable IP HDR csum calculation for V4 pkts */
+ hdr->csum_l3 = (ip.v4->version == 4) ? 1 : 0;
proto = (ip.v4->version == 4) ? ip.v4->protocol :
ip.v6->nexthdr;
--
2.15.0
next reply other threads:[~2017-11-22 12:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 12:37 Aleksey Makarov [this message]
2017-11-22 15:57 ` Eric Dumazet
2017-11-23 4:19 ` Sunil Kovvuri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171122123727.23580-1-aleksey.makarov@auriga.com \
--to=aleksey.makarov@auriga.com \
--cc=Sunil.Goutham@cavium.com \
--cc=aleksey.makarov@cavium.com \
--cc=fw@strlen.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rric@kernel.org \
--cc=sgoutham@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®