mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefano Manni <stefano.manni@gmail.com>
To: Oleg Drokin <oleg.drokin@intel.com>,
	Andreas Dilger <andreas.dilger@intel.com>,
	James Simmons <jsimmons@infradead.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org, stefano.manni@gmail.com
Subject: [PATCH 3/4] staging: lustre: fixed signedness of lov
Date: Wed, 22 Nov 2017 20:38:30 +0100	[thread overview]
Message-ID: <20171122193831.11801-4-stefano.manni@gmail.com> (raw)
In-Reply-To: <20171122193831.11801-1-stefano.manni@gmail.com>

sparse warning on lov_obd.c:
warning: incorrect type in argument 3 (different signedness)
expected int *res
got unsigned int [usertype] *i

sparse warning on lov_offset.c:
warning: incorrect type in argument 4 (different signedness)
expected long long [usertype] *<noident>
got unsigned long long *<noident>

Signed-off-by: Stefano Manni <stefano.manni@gmail.com>
---
 drivers/staging/lustre/lustre/lov/lov_obd.c    |  2 +-
 drivers/staging/lustre/lustre/lov/lov_offset.c | 11 +++++++----
 2 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/lustre/lustre/lov/lov_obd.c b/drivers/staging/lustre/lustre/lov/lov_obd.c
index 7ce0102..3cccd79 100644
--- a/drivers/staging/lustre/lustre/lov/lov_obd.c
+++ b/drivers/staging/lustre/lustre/lov/lov_obd.c
@@ -899,7 +899,7 @@ int lov_process_config_base(struct obd_device *obd, struct lustre_cfg *lcfg,
 
 		obd_str2uuid(&obd_uuid,  lustre_cfg_buf(lcfg, 1));
 
-		rc = kstrtoint(lustre_cfg_buf(lcfg, 2), 10, indexp);
+		rc = kstrtouint(lustre_cfg_buf(lcfg, 2), 10, indexp);
 		if (rc < 0)
 			goto out;
 		rc = kstrtoint(lustre_cfg_buf(lcfg, 3), 10, genp);
diff --git a/drivers/staging/lustre/lustre/lov/lov_offset.c b/drivers/staging/lustre/lustre/lov/lov_offset.c
index 3e16e64..954a01b 100644
--- a/drivers/staging/lustre/lustre/lov/lov_offset.c
+++ b/drivers/staging/lustre/lustre/lov/lov_offset.c
@@ -44,7 +44,7 @@ u64 lov_stripe_size(struct lov_stripe_md *lsm, u64 ost_size, int stripeno)
 {
 	unsigned long ssize = lsm->lsm_stripe_size;
 	unsigned long stripe_size;
-	u64 swidth;
+	long long swidth;
 	u64 lov_size;
 	int magic = lsm->lsm_magic;
 
@@ -128,7 +128,8 @@ int lov_stripe_offset(struct lov_stripe_md *lsm, u64 lov_off,
 		      int stripeno, u64 *obdoff)
 {
 	unsigned long ssize  = lsm->lsm_stripe_size;
-	u64 stripe_off, this_stripe, swidth;
+	long long swidth;
+	u64 stripe_off, this_stripe;
 	int magic = lsm->lsm_magic;
 	int ret = 0;
 
@@ -183,7 +184,8 @@ u64 lov_size_to_stripe(struct lov_stripe_md *lsm, u64 file_size,
 		       int stripeno)
 {
 	unsigned long ssize  = lsm->lsm_stripe_size;
-	u64 stripe_off, this_stripe, swidth;
+	long long swidth;
+	u64 stripe_off, this_stripe;
 	int magic = lsm->lsm_magic;
 
 	if (file_size == OBD_OBJECT_EOF)
@@ -257,7 +259,8 @@ int lov_stripe_intersects(struct lov_stripe_md *lsm, int stripeno,
 int lov_stripe_number(struct lov_stripe_md *lsm, u64 lov_off)
 {
 	unsigned long ssize  = lsm->lsm_stripe_size;
-	u64 stripe_off, swidth;
+	long long swidth;
+	u64 stripe_off;
 	int magic = lsm->lsm_magic;
 
 	lsm_op_find(magic)->lsm_stripe_by_offset(lsm, NULL, &lov_off, &swidth);
-- 
2.5.5

  parent reply	other threads:[~2017-11-22 19:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-22 19:38 [PATCH 0/4] staging: lustre: fixed some signedness warns from sparse Stefano Manni
2017-11-22 19:38 ` [PATCH 1/4] staging: lustre: fixed signedness of some socklnd params Stefano Manni
2017-11-23 12:13   ` Dan Carpenter
2017-11-23 23:47     ` Stefano Manni
2017-11-24 12:49       ` Dan Carpenter
2017-11-22 19:38 ` [PATCH 2/4] staging: lustre: fixed signedness of llite Stefano Manni
2017-11-22 19:38 ` Stefano Manni [this message]
2017-11-24 15:42   ` [PATCH 3/4] staging: lustre: fixed signedness of lov Greg Kroah-Hartman
2017-11-22 19:38 ` [PATCH 4/4] staging: lustre: fixed signedness of obdclass Stefano Manni
2017-11-23  4:59 ` [PATCH 0/4] staging: lustre: fixed some signedness warns from sparse Tobin C. Harding
2017-11-23 11:51   ` Dan Carpenter
2017-11-23 22:20     ` Tobin C. Harding
2017-11-23 23:32       ` Stefano Manni
2017-11-24 13:02       ` Dan Carpenter
2017-11-24 21:37         ` Tobin C. Harding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171122193831.11801-4-stefano.manni@gmail.com \
    --to=stefano.manni@gmail.com \
    --cc=andreas.dilger@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jsimmons@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lustre-devel@lists.lustre.org \
    --cc=oleg.drokin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®