From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Tobin C. Harding" <me@tobin.cc>
Cc: Stefano Manni <stefano.manni@gmail.com>,
devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Oleg Drokin <oleg.drokin@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>,
lustre-devel@lists.lustre.org
Subject: Re: [PATCH 0/4] staging: lustre: fixed some signedness warns from sparse
Date: Thu, 23 Nov 2017 14:51:38 +0300 [thread overview]
Message-ID: <20171123115138.5nku6epnct35mmha@mwanda> (raw)
In-Reply-To: <20171123045926.GD12736@eros>
On Thu, Nov 23, 2017 at 03:59:26PM +1100, Tobin C. Harding wrote:
> On Wed, Nov 22, 2017 at 08:38:27PM +0100, Stefano Manni wrote:
> > Fixed some signedness warnings from sparse on lustre.
> >
> > Stefano Manni (4):
> > staging: lustre: fixed signedness of some socklnd params
> > staging: lustre: fixed signedness of llite
> > staging: lustre: fixed signedness of lov
> > staging: lustre: fixed signedness of obdclass
>
> You may like to use imperative mood for your git log brief descriptions
> Stefano.
>
> s/fixed/fix/
>
Someone once chewed me a second butt hole for not using the imperative
mood so I know some people care intensely about this but I think so long
as you can understand the description it's fine. I will never send a
patch for that maintainer's subsystem again, btw, which is probably
grateful for and now I can poop twice as fast so we're both winners.
Especially in the 0/4 patch which is going to be discarded. Who cares?
regards,
dan carpenter
next prev parent reply other threads:[~2017-11-23 11:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 19:38 Stefano Manni
2017-11-22 19:38 ` [PATCH 1/4] staging: lustre: fixed signedness of some socklnd params Stefano Manni
2017-11-23 12:13 ` Dan Carpenter
2017-11-23 23:47 ` Stefano Manni
2017-11-24 12:49 ` Dan Carpenter
2017-11-22 19:38 ` [PATCH 2/4] staging: lustre: fixed signedness of llite Stefano Manni
2017-11-22 19:38 ` [PATCH 3/4] staging: lustre: fixed signedness of lov Stefano Manni
2017-11-24 15:42 ` Greg Kroah-Hartman
2017-11-22 19:38 ` [PATCH 4/4] staging: lustre: fixed signedness of obdclass Stefano Manni
2017-11-23 4:59 ` [PATCH 0/4] staging: lustre: fixed some signedness warns from sparse Tobin C. Harding
2017-11-23 11:51 ` Dan Carpenter [this message]
2017-11-23 22:20 ` Tobin C. Harding
2017-11-23 23:32 ` Stefano Manni
2017-11-24 13:02 ` Dan Carpenter
2017-11-24 21:37 ` Tobin C. Harding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171123115138.5nku6epnct35mmha@mwanda \
--to=dan.carpenter@oracle.com \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=me@tobin.cc \
--cc=oleg.drokin@intel.com \
--cc=stefano.manni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®