From: "greg@kroah.com" <greg@kroah.com>
To: Hartley Sweeten <HartleyS@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>,
Alex Frappier Lachapelle <alex.frappierlachapelle@gmail.com>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Staging: comedi: das16: Fixed a const struct coding style issue
Date: Tue, 28 Nov 2017 07:59:49 +0100 [thread overview]
Message-ID: <20171128065949.GB6489@kroah.com> (raw)
In-Reply-To: <SN1PR0101MB1565C55D9AA09BC43DD32A35D0250@SN1PR0101MB1565.prod.exchangelabs.com>
On Mon, Nov 27, 2017 at 05:51:56PM +0000, Hartley Sweeten wrote:
> On Monday, November 27, 2017 3:28 AM, Ian Abbott wrote:
> > On 26/11/17 01:50, Alex Frappier Lachapelle wrote:
> >> + const struct comedi_lrange *lrange;
> >
> > NAK. The following lines of source code allocate memory pointed to by 'lrange' and modify it, so 'const' is not appropriate here.
>
> Ian,
>
> Wonder if it's worth putting a comment about this in the code. This has come up a
> couple times.
It's a nice test to see who actually builds the code before they send a
patch in :)
next prev parent reply other threads:[~2017-11-28 6:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-26 1:50 Alex Frappier Lachapelle
2017-11-27 10:28 ` Ian Abbott
2017-11-27 17:51 ` Hartley Sweeten
2017-11-27 22:36 ` Dan Carpenter
2017-11-28 6:59 ` greg [this message]
2017-11-28 2:37 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171128065949.GB6489@kroah.com \
--to=greg@kroah.com \
--cc=HartleyS@visionengravers.com \
--cc=abbotti@mev.co.uk \
--cc=alex.frappierlachapelle@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®