* [PATCH] cgroup: properly init u64_stats
@ 2017-11-28 12:59 Lucas Stach
2017-11-28 15:17 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Lucas Stach @ 2017-11-28 12:59 UTC (permalink / raw)
To: Tejun Heo; +Cc: Peter Zijlstra, linux-kernel, kernel, patchwork-lst
Lockdep complains that the stats update is trying to register a non-static
key. This is because u64_stats are using a seqlock on 32bit arches, which
needs to be initialized before usage.
Fixes: 041cd640b2f3 (cgroup: Implement cgroup2 basic CPU usage accounting)
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
kernel/cgroup/stat.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/kernel/cgroup/stat.c b/kernel/cgroup/stat.c
index 133b465691d6..1e111dd455c4 100644
--- a/kernel/cgroup/stat.c
+++ b/kernel/cgroup/stat.c
@@ -296,8 +296,12 @@ int cgroup_stat_init(struct cgroup *cgrp)
}
/* ->updated_children list is self terminated */
- for_each_possible_cpu(cpu)
- cgroup_cpu_stat(cgrp, cpu)->updated_children = cgrp;
+ for_each_possible_cpu(cpu) {
+ struct cgroup_cpu_stat *cstat = cgroup_cpu_stat(cgrp, cpu);
+
+ cstat->updated_children = cgrp;
+ u64_stats_init(&cstat->sync);
+ }
prev_cputime_init(&cgrp->stat.prev_cputime);
--
2.11.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] cgroup: properly init u64_stats
2017-11-28 12:59 [PATCH] cgroup: properly init u64_stats Lucas Stach
@ 2017-11-28 15:17 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2017-11-28 15:17 UTC (permalink / raw)
To: Lucas Stach; +Cc: Peter Zijlstra, linux-kernel, kernel, patchwork-lst
On Tue, Nov 28, 2017 at 01:59:25PM +0100, Lucas Stach wrote:
> Lockdep complains that the stats update is trying to register a non-static
> key. This is because u64_stats are using a seqlock on 32bit arches, which
> needs to be initialized before usage.
>
> Fixes: 041cd640b2f3 (cgroup: Implement cgroup2 basic CPU usage accounting)
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Applied to cgroup/for-4.15-fixes.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-28 15:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-28 12:59 [PATCH] cgroup: properly init u64_stats Lucas Stach
2017-11-28 15:17 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome