* [PATCH ipsec] xfrm: fix XFRMA_OUTPUT_MARK policy entry
@ 2017-11-29 17:23 Michal Kubecek
2017-12-01 6:00 ` Steffen Klassert
0 siblings, 1 reply; 2+ messages in thread
From: Michal Kubecek @ 2017-11-29 17:23 UTC (permalink / raw)
To: Steffen Klassert
Cc: Herbert Xu, David S. Miller, Lorenzo Colitti, netdev, linux-kernel
This seems to be an obvious typo, NLA_U32 is type of the attribute, not its
(minimal) length.
Fixes: 077fbac405bf ("net: xfrm: support setting an output mark.")
Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
---
net/xfrm/xfrm_user.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c
index c2cfcc6fdb34..ff58c37469d6 100644
--- a/net/xfrm/xfrm_user.c
+++ b/net/xfrm/xfrm_user.c
@@ -2485,7 +2485,7 @@ static const struct nla_policy xfrma_policy[XFRMA_MAX+1] = {
[XFRMA_PROTO] = { .type = NLA_U8 },
[XFRMA_ADDRESS_FILTER] = { .len = sizeof(struct xfrm_address_filter) },
[XFRMA_OFFLOAD_DEV] = { .len = sizeof(struct xfrm_user_offload) },
- [XFRMA_OUTPUT_MARK] = { .len = NLA_U32 },
+ [XFRMA_OUTPUT_MARK] = { .type = NLA_U32 },
};
static const struct nla_policy xfrma_spd_policy[XFRMA_SPD_MAX+1] = {
--
2.15.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH ipsec] xfrm: fix XFRMA_OUTPUT_MARK policy entry
2017-11-29 17:23 [PATCH ipsec] xfrm: fix XFRMA_OUTPUT_MARK policy entry Michal Kubecek
@ 2017-12-01 6:00 ` Steffen Klassert
0 siblings, 0 replies; 2+ messages in thread
From: Steffen Klassert @ 2017-12-01 6:00 UTC (permalink / raw)
To: Michal Kubecek
Cc: Herbert Xu, David S. Miller, Lorenzo Colitti, netdev, linux-kernel
On Wed, Nov 29, 2017 at 06:23:56PM +0100, Michal Kubecek wrote:
> This seems to be an obvious typo, NLA_U32 is type of the attribute, not its
> (minimal) length.
>
> Fixes: 077fbac405bf ("net: xfrm: support setting an output mark.")
> Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
Patch applied, thanks Michal!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-01 6:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-29 17:23 [PATCH ipsec] xfrm: fix XFRMA_OUTPUT_MARK policy entry Michal Kubecek
2017-12-01 6:00 ` Steffen Klassert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®