mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Radim Krčmář" <rkrcmar@redhat.com>
To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Borislav Petkov" <bp@alien8.de>,
	"Alexander Graf" <agraf@suse.de>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Jan H. Schönherr" <jschoenh@amazon.de>,
	"KarimAllah Ahmed" <karahmed@amazon.de>,
	"Jim Mattson" <jmattson@google.com>
Subject: [PATCH v2 1/3] KVM: x86: prevent MWAIT in guest with buggy MONITOR
Date: Wed, 29 Nov 2017 22:23:41 +0100	[thread overview]
Message-ID: <20171129212343.23167-2-rkrcmar@redhat.com> (raw)
In-Reply-To: <20171129212343.23167-1-rkrcmar@redhat.com>

The bug prevents MWAIT from waking up after a write to the monitored
cache line.
KVM might emulate a CPU model that shouldn't have the bug, so the guest
would not employ a workaround and possibly miss wakeups.
Better to avoid the situation.

Reviewed-by: Alexander Graf <agraf@suse.de>
Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
---
 arch/x86/kvm/x86.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/x86/kvm/x86.h b/arch/x86/kvm/x86.h
index d0b95b7a90b4..81f5f50794f6 100644
--- a/arch/x86/kvm/x86.h
+++ b/arch/x86/kvm/x86.h
@@ -281,6 +281,9 @@ static inline bool kvm_mwait_in_guest(void)
 		return false;
 	}
 
+	if (boot_cpu_has_bug(X86_BUG_MONITOR))
+		return false;
+
 	/*
 	 * Intel CPUs without CPUID5_ECX_INTERRUPT_BREAK are problematic as
 	 * they would allow guest to stop the CPU completely by disabling
-- 
2.14.2

  reply	other threads:[~2017-11-29 21:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-29 21:23 [PATCH v2 0/3] KVM: x86: kvm_mwait_in_guest() cleanup Radim Krčmář
2017-11-29 21:23 ` Radim Krčmář [this message]
2017-11-29 21:23 ` [PATCH v2 2/3] KVM: x86: drop bogus MWAIT check Radim Krčmář
2017-11-29 21:23 ` [PATCH v2 3/3] KVM: x86: simplify kvm_mwait_in_guest() Radim Krčmář
2017-11-30 13:12 ` [PATCH v2 0/3] KVM: x86: kvm_mwait_in_guest() cleanup Borislav Petkov
2017-11-30 14:19 ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171129212343.23167-2-rkrcmar@redhat.com \
    --to=rkrcmar@redhat.com \
    --cc=agraf@suse.de \
    --cc=bp@alien8.de \
    --cc=jmattson@google.com \
    --cc=jschoenh@amazon.de \
    --cc=karahmed@amazon.de \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®