mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] NTB: ntb_hw_idt: Set NTB_TOPO_SWITCH topology
@ 2017-11-30 21:41 Serge Semin
  2017-11-30 22:06 ` Logan Gunthorpe
  0 siblings, 1 reply; 4+ messages in thread
From: Serge Semin @ 2017-11-30 21:41 UTC (permalink / raw)
  To: jdmason, dave.jiang, Allen.Hubbe, Shyam-sundar.S-k, Xiangliang.Yu
  Cc: Sergey.Semin, linux-ntb, linux-kernel, Serge Semin

Since Switchtec patch there has been a new topology added to
the NTB API. It's called NTB_TOPO_SWITCH and dedicated for
PCIe switch chips. Even though topo field isn't used within the
IDT driver much, lets set it for the sake of unification.

Signed-off-by: Serge Semin <fancer.lancer@gmail.com>
Acked-by: Serge Semin <fancer.lancer@gmail.com>
---
 drivers/ntb/hw/idt/ntb_hw_idt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ntb/hw/idt/ntb_hw_idt.c b/drivers/ntb/hw/idt/ntb_hw_idt.c
index d87dbd4bc82c..27fdd14e0dca 100644
--- a/drivers/ntb/hw/idt/ntb_hw_idt.c
+++ b/drivers/ntb/hw/idt/ntb_hw_idt.c
@@ -2070,7 +2070,7 @@ static int idt_register_device(struct idt_ntb_dev *ndev)
 
 	/* Initialize the rest of NTB device structure and register it */
 	ndev->ntb.ops = &idt_ntb_ops;
-	ndev->ntb.topo = NTB_TOPO_PRI;
+	ndev->ntb.topo = NTB_TOPO_SWITCH;
 
 	ret = ntb_register_device(&ndev->ntb);
 	if (ret != 0) {
-- 
2.12.0

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] NTB: ntb_hw_idt: Set NTB_TOPO_SWITCH topology
  2017-11-30 21:41 [PATCH] NTB: ntb_hw_idt: Set NTB_TOPO_SWITCH topology Serge Semin
@ 2017-11-30 22:06 ` Logan Gunthorpe
  2017-11-30 22:14   ` Serge Semin
  0 siblings, 1 reply; 4+ messages in thread
From: Logan Gunthorpe @ 2017-11-30 22:06 UTC (permalink / raw)
  To: Serge Semin, jdmason, dave.jiang, Allen.Hubbe, Shyam-sundar.S-k,
	Xiangliang.Yu
  Cc: Sergey.Semin, linux-ntb, linux-kernel



On 30/11/17 02:41 PM, Serge Semin wrote:
> Since Switchtec patch there has been a new topology added to
> the NTB API. It's called NTB_TOPO_SWITCH and dedicated for
> PCIe switch chips. Even though topo field isn't used within the
> IDT driver much, lets set it for the sake of unification.
> 
> Signed-off-by: Serge Semin <fancer.lancer@gmail.com>
> Acked-by: Serge Semin <fancer.lancer@gmail.com>

You don't need to Ack your own patches ;)

Reviewed-by: Logan Gunthorpe <logang@deltatee.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] NTB: ntb_hw_idt: Set NTB_TOPO_SWITCH topology
  2017-11-30 22:06 ` Logan Gunthorpe
@ 2017-11-30 22:14   ` Serge Semin
  2017-11-30 22:27     ` Logan Gunthorpe
  0 siblings, 1 reply; 4+ messages in thread
From: Serge Semin @ 2017-11-30 22:14 UTC (permalink / raw)
  To: Logan Gunthorpe
  Cc: jdmason, dave.jiang, Allen.Hubbe, Shyam-sundar.S-k,
	Xiangliang.Yu, Sergey.Semin, linux-ntb, linux-kernel

On Thu, Nov 30, 2017 at 03:06:15PM -0700, Logan Gunthorpe <logang@deltatee.com> wrote:
> 
> 
> On 30/11/17 02:41 PM, Serge Semin wrote:
> >Since Switchtec patch there has been a new topology added to
> >the NTB API. It's called NTB_TOPO_SWITCH and dedicated for
> >PCIe switch chips. Even though topo field isn't used within the
> >IDT driver much, lets set it for the sake of unification.
> >
> >Signed-off-by: Serge Semin <fancer.lancer@gmail.com>
> >Acked-by: Serge Semin <fancer.lancer@gmail.com>
> 
> You don't need to Ack your own patches ;)
> 

It goes to the subsystem maintained by me. I tested the change, so am responsible
for the results.

> Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
> 
> -- 
> You received this message because you are subscribed to the Google Groups "linux-ntb" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-ntb+unsubscribe@googlegroups.com.
> To post to this group, send email to linux-ntb@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/linux-ntb/05386287-e0c2-5dd3-4e9b-6f64c61f8405%40deltatee.com.
> For more options, visit https://groups.google.com/d/optout.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] NTB: ntb_hw_idt: Set NTB_TOPO_SWITCH topology
  2017-11-30 22:14   ` Serge Semin
@ 2017-11-30 22:27     ` Logan Gunthorpe
  0 siblings, 0 replies; 4+ messages in thread
From: Logan Gunthorpe @ 2017-11-30 22:27 UTC (permalink / raw)
  To: Serge Semin
  Cc: jdmason, dave.jiang, Allen.Hubbe, Shyam-sundar.S-k,
	Xiangliang.Yu, Sergey.Semin, linux-ntb, linux-kernel



On 30/11/17 03:14 PM, Serge Semin wrote:
>>> Signed-off-by: Serge Semin <fancer.lancer@gmail.com>
>>> Acked-by: Serge Semin <fancer.lancer@gmail.com>
>>
>> You don't need to Ack your own patches ;)
>>
> 
> It goes to the subsystem maintained by me. I tested the change, so am responsible
> for the results.

Yes, but it goes without saying that a patch you wrote, you ack.

Logan

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-11-30 22:27 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-30 21:41 [PATCH] NTB: ntb_hw_idt: Set NTB_TOPO_SWITCH topology Serge Semin
2017-11-30 22:06 ` Logan Gunthorpe
2017-11-30 22:14   ` Serge Semin
2017-11-30 22:27     ` Logan Gunthorpe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®