mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 0/3] misc: ics932s401: warnings and errors are resolved.
@ 2017-12-08  5:56 Dhaval Shah
  2017-12-08  5:56 ` [PATCH 1/3] misc: ics932s401: Missing a blank line after declarations Dhaval Shah
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Dhaval Shah @ 2017-12-08  5:56 UTC (permalink / raw)
  To: arnd, gregkh; +Cc: linux-kernel, Dhaval Shah

Two types of checkpatch warnings and one type of error are resolved.
 * First patch  : Missing a blank line after declarations
 * Second patch : please, no space before tabs
 * third patch  : open brace { should be on the previous line

Issue found by checkpatch.
./scripts/checkpatch.pl -f --strict drivers/misc/hpilo.c


Dhaval Shah (3):
  misc: ics932s401: Missing a blank line after declarations
  misc: ics932s401: please, no space before tabs
  misc: ics932s401: open brace should be on the previous line

 drivers/misc/ics932s401.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

-- 
2.11.0

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/3] misc: ics932s401: Missing a blank line after declarations
  2017-12-08  5:56 [PATCH 0/3] misc: ics932s401: warnings and errors are resolved Dhaval Shah
@ 2017-12-08  5:56 ` Dhaval Shah
  2017-12-08  5:56 ` [PATCH 2/3] misc: ics932s401: please, no space before tabs Dhaval Shah
  2017-12-08  5:56 ` [PATCH 3/3] misc: ics932s401: open brace should be on the previous line Dhaval Shah
  2 siblings, 0 replies; 4+ messages in thread
From: Dhaval Shah @ 2017-12-08  5:56 UTC (permalink / raw)
  To: arnd, gregkh; +Cc: linux-kernel, Dhaval Shah

Resolved all the missing a blank line after declarations checkpatch
warnings. Issue found by checkpatch.

Signed-off-by: Dhaval Shah <dhaval.shah@softnautics.com>
---
 drivers/misc/ics932s401.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/misc/ics932s401.c b/drivers/misc/ics932s401.c
index 28f51e01fd2b..d22e2dc62907 100644
--- a/drivers/misc/ics932s401.c
+++ b/drivers/misc/ics932s401.c
@@ -225,6 +225,7 @@ static ssize_t show_cpu_clock_sel(struct device *dev,
 	else {
 		/* Freq is neatly wrapped up for us */
 		int fid = data->regs[ICS932S401_REG_CFG7] & ICS932S401_FS_MASK;
+
 		freq = fs_speeds[fid];
 		if (data->regs[ICS932S401_REG_CTRL] & ICS932S401_CPU_ALT) {
 			switch (freq) {
-- 
2.11.0

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 2/3] misc: ics932s401: please, no space before tabs
  2017-12-08  5:56 [PATCH 0/3] misc: ics932s401: warnings and errors are resolved Dhaval Shah
  2017-12-08  5:56 ` [PATCH 1/3] misc: ics932s401: Missing a blank line after declarations Dhaval Shah
@ 2017-12-08  5:56 ` Dhaval Shah
  2017-12-08  5:56 ` [PATCH 3/3] misc: ics932s401: open brace should be on the previous line Dhaval Shah
  2 siblings, 0 replies; 4+ messages in thread
From: Dhaval Shah @ 2017-12-08  5:56 UTC (permalink / raw)
  To: arnd, gregkh; +Cc: linux-kernel, Dhaval Shah

Resolved all the please, no space beofore tabs checkpatch
warnings. Issue found by checkpatch.

Signed-off-by: Dhaval Shah <dhaval.shah@softnautics.com>
---
 drivers/misc/ics932s401.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/ics932s401.c b/drivers/misc/ics932s401.c
index d22e2dc62907..12177db99ce1 100644
--- a/drivers/misc/ics932s401.c
+++ b/drivers/misc/ics932s401.c
@@ -33,7 +33,7 @@ static const unsigned short normal_i2c[] = { 0x69, I2C_CLIENT_END };
 
 /* ICS932S401 registers */
 #define ICS932S401_REG_CFG2			0x01
-#define 	ICS932S401_CFG1_SPREAD		0x01
+#define		ICS932S401_CFG1_SPREAD		0x01
 #define ICS932S401_REG_CFG7			0x06
 #define		ICS932S401_FS_MASK		0x07
 #define	ICS932S401_REG_VENDOR_REV		0x07
@@ -58,7 +58,7 @@ static const unsigned short normal_i2c[] = { 0x69, I2C_CLIENT_END };
 #define	ICS932S401_REG_SRC_SPREAD1		0x11
 #define ICS932S401_REG_SRC_SPREAD2		0x12
 #define ICS932S401_REG_CPU_DIVISOR		0x13
-#define 	ICS932S401_CPU_DIVISOR_SHIFT	4
+#define		ICS932S401_CPU_DIVISOR_SHIFT	4
 #define ICS932S401_REG_PCISRC_DIVISOR		0x14
 #define		ICS932S401_SRC_DIVISOR_MASK	0x0F
 #define		ICS932S401_PCI_DIVISOR_SHIFT	4
-- 
2.11.0

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 3/3] misc: ics932s401: open brace should be on the previous line
  2017-12-08  5:56 [PATCH 0/3] misc: ics932s401: warnings and errors are resolved Dhaval Shah
  2017-12-08  5:56 ` [PATCH 1/3] misc: ics932s401: Missing a blank line after declarations Dhaval Shah
  2017-12-08  5:56 ` [PATCH 2/3] misc: ics932s401: please, no space before tabs Dhaval Shah
@ 2017-12-08  5:56 ` Dhaval Shah
  2 siblings, 0 replies; 4+ messages in thread
From: Dhaval Shah @ 2017-12-08  5:56 UTC (permalink / raw)
  To: arnd, gregkh; +Cc: linux-kernel, Dhaval Shah

Resolved open brace { should be on the previous line checkpatch
error. Issue found by checkpatch.

Signed-off-by: Dhaval Shah <dhaval.shah@softnautics.com>
---
 drivers/misc/ics932s401.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/misc/ics932s401.c b/drivers/misc/ics932s401.c
index 12177db99ce1..81a0541ef3ac 100644
--- a/drivers/misc/ics932s401.c
+++ b/drivers/misc/ics932s401.c
@@ -353,8 +353,7 @@ static DEVICE_ATTR(ref_clock, S_IRUGO, show_value, NULL);
 static DEVICE_ATTR(cpu_spread, S_IRUGO, show_spread, NULL);
 static DEVICE_ATTR(src_spread, S_IRUGO, show_spread, NULL);
 
-static struct attribute *ics932s401_attr[] =
-{
+static struct attribute *ics932s401_attr[] = {
 	&dev_attr_spread_enabled.attr,
 	&dev_attr_cpu_clock_selection.attr,
 	&dev_attr_cpu_clock.attr,
-- 
2.11.0

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-12-08  5:57 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-08  5:56 [PATCH 0/3] misc: ics932s401: warnings and errors are resolved Dhaval Shah
2017-12-08  5:56 ` [PATCH 1/3] misc: ics932s401: Missing a blank line after declarations Dhaval Shah
2017-12-08  5:56 ` [PATCH 2/3] misc: ics932s401: please, no space before tabs Dhaval Shah
2017-12-08  5:56 ` [PATCH 3/3] misc: ics932s401: open brace should be on the previous line Dhaval Shah

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®