mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ioana Radulescu <ruxandra.radulescu@nxp.com>
To: <gregkh@linuxfoundation.org>
Cc: <devel@driverdev.osuosl.org>, <linux-kernel@vger.kernel.org>,
	<bogdan.purcareata@nxp.com>
Subject: [PATCH 0/6] staging: fsl-dpaa2/eth: Frame buffer optimizations
Date: Fri, 8 Dec 2017 06:47:52 -0600	[thread overview]
Message-ID: <20171208124758.2732-1-ruxandra.radulescu@nxp.com> (raw)

This patchset continues the work related to frame buffer layout.

The first two patches fix an issue and simplify some rather convoluted
formulas introduced by a previous commit.

The third adds a new counter for TX skb reallocations due to
insufficient headroom. This helped us notice that most of the frames
originated on the core had skbs with too little headroom, leading to
additional alloc/free operations and a performance penalty for
egress termination traffic.

A closer look at hardware requirements vs recommandations showed
that we don't in fact need to be so strict with our TX buffer layout.
The last three patches in this set remove all restrictions that are
not mandatory from a functional standpoint, lowering the required
TX headroom from 192B to 64B.

This helps avoid realloc's for most TCP frames. On a LS2088A board
with one core @2GHz, running a netperf TCP_SENDFILE test (as client),
we see an increase in throughput from 3.79Gbps to 5.11Gbps. For UDP
traffic no improvement is observed, since the stack usually creates
skbs with minimal headroom (2B) for UDP frames.

Ioana Radulescu (6):
  staging: fsl-dpaa2/eth: Fix access to FAS field
  staging: fsl-dpaa2/eth: Don't set netdev->needed_headroom
  staging: fsl-dpaa2/eth: Add counter for skb reallocs
  staging: fsl-dpaa2/eth: Don't enable FAS on Tx
  staging: fsl-dpaa2/eth: Compute needed headroom per frame
  staging: fsl-dpaa2/eth: Make Tx buffer alignment optional

 drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c     | 111 +++++----------------
 drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h     |  31 +++---
 drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c |   1 +
 3 files changed, 46 insertions(+), 97 deletions(-)

-- 
2.7.4

             reply	other threads:[~2017-12-08 12:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-08 12:47 Ioana Radulescu [this message]
2017-12-08 12:47 ` [PATCH 1/6] staging: fsl-dpaa2/eth: Fix access to FAS field Ioana Radulescu
2017-12-08 12:47 ` [PATCH 2/6] staging: fsl-dpaa2/eth: Don't set netdev->needed_headroom Ioana Radulescu
2017-12-08 12:47 ` [PATCH 3/6] staging: fsl-dpaa2/eth: Add counter for skb reallocs Ioana Radulescu
2017-12-08 12:47 ` [PATCH 4/6] staging: fsl-dpaa2/eth: Don't enable FAS on Tx Ioana Radulescu
2017-12-08 12:47 ` [PATCH 5/6] staging: fsl-dpaa2/eth: Compute needed headroom per frame Ioana Radulescu
2017-12-08 12:47 ` [PATCH 6/6] staging: fsl-dpaa2/eth: Make Tx buffer alignment optional Ioana Radulescu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171208124758.2732-1-ruxandra.radulescu@nxp.com \
    --to=ruxandra.radulescu@nxp.com \
    --cc=bogdan.purcareata@nxp.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®