From: Bjorn Helgaas <helgaas@kernel.org>
To: Govinda Tatti <Govinda.Tatti@Oracle.COM>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, bhelgaas@google.com,
boris.ostrovsky@Oracle.COM, jgross@suse.com, JBeulich@suse.com,
roger.pau@citrix.com, konrad.wilk@Oracle.COM
Subject: Re: [PATCH V3 1/2] Drivers/PCI: Export pcie_has_flr() interface
Date: Fri, 8 Dec 2017 14:24:24 -0600 [thread overview]
Message-ID: <20171208202424.GC12367@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <20171207222145.9769-2-Govinda.Tatti@Oracle.COM>
On Thu, Dec 07, 2017 at 05:21:44PM -0500, Govinda Tatti wrote:
> This patch exports pcie_has_flr() and it is being used by Xen pciback
> driver to reset (flr/slot/bus) PCI devices based on 'reset' SysFS
> attribute.
>
> Signed-off-by: Govinda Tatti <Govinda.Tatti@Oracle.COM>
> ---
> v3: -New
>
> drivers/pci/pci.c | 3 ++-
> include/linux/pci.h | 1 +
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 6078dfc..499e922 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -3872,7 +3872,7 @@ static void pci_flr_wait(struct pci_dev *dev)
> * Returns true if the device advertises support for PCIe function level
> * resets.
> */
> -static bool pcie_has_flr(struct pci_dev *dev)
> +bool pcie_has_flr(struct pci_dev *dev)
> {
> u32 cap;
>
> @@ -3882,6 +3882,7 @@ static bool pcie_has_flr(struct pci_dev *dev)
> pcie_capability_read_dword(dev, PCI_EXP_DEVCAP, &cap);
> return cap & PCI_EXP_DEVCAP_FLR;
> }
> +EXPORT_SYMBOL_GPL(pcie_has_flr);
I'd rather change pcie_flr() so you could *always* call it, and it
would return 0, -ENOTTY, or whatever, based on whether FLR is
supported. Is that feasible?
I don't like the "Can I do this? Ok, do this" style of interfaces.
It's racy (not really applicable in this case) and seems clunky.
> /**
> * pcie_flr - initiate a PCIe function level reset
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index d16a7c0..44bf2b5 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -1089,6 +1089,7 @@ int pcie_get_mps(struct pci_dev *dev);
> int pcie_set_mps(struct pci_dev *dev, int mps);
> int pcie_get_minimum_link(struct pci_dev *dev, enum pci_bus_speed *speed,
> enum pcie_link_width *width);
> +bool pcie_has_flr(struct pci_dev *dev);
> void pcie_flr(struct pci_dev *dev);
> int __pci_reset_function(struct pci_dev *dev);
> int __pci_reset_function_locked(struct pci_dev *dev);
> --
> 2.9.5
>
next prev parent reply other threads:[~2017-12-08 20:24 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 22:21 [PATCH V3 0/2] Xen/PCIback: PCI reset using 'reset' SysFS attribute Govinda Tatti
2017-12-07 22:21 ` [PATCH V3 1/2] Drivers/PCI: Export pcie_has_flr() interface Govinda Tatti
2017-12-08 20:24 ` Bjorn Helgaas [this message]
2017-12-12 0:29 ` Govinda Tatti
2017-12-12 0:59 ` Bjorn Helgaas
2017-12-13 20:46 ` [Xen-devel] " Govinda Tatti
2017-12-13 21:24 ` Bjorn Helgaas
2017-12-14 12:52 ` Christoph Hellwig
2017-12-15 0:24 ` Bjorn Helgaas
2017-12-15 15:48 ` Govinda Tatti
2017-12-15 18:18 ` Bjorn Helgaas
2017-12-15 20:01 ` Govinda Tatti
2017-12-18 3:09 ` Alexey Kardashevskiy
2017-12-18 12:26 ` Christoph Hellwig
2017-12-18 17:22 ` Govinda Tatti
2018-09-09 18:59 ` Pasi Kärkkäinen
2018-09-10 2:33 ` Sinan Kaya
2018-09-10 9:52 ` Pasi Kärkkäinen
2018-09-10 17:04 ` Sinan Kaya
2017-12-12 15:07 ` Christoph Hellwig
2017-12-07 22:21 ` [PATCH V3 2/2] Xen/PCIback: Implement PCI flr/slot/bus reset with 'reset' SysFS attribute Govinda Tatti
2017-12-08 9:34 ` Jan Beulich
2017-12-12 15:01 ` Govinda Tatti
[not found] ` <8a3bc517-1255-4547-d244-5c400e44cc77@Oracle.COM>
2017-12-12 15:01 ` Jan Beulich
2017-12-12 15:14 ` [Xen-devel] " Govinda Tatti
2017-12-15 19:52 ` Govinda Tatti
2017-12-18 7:36 ` Jan Beulich
2017-12-18 17:32 ` Boris Ostrovsky
2018-09-16 11:43 ` [Xen-devel] " Pasi Kärkkäinen
2018-09-17 18:06 ` Boris Ostrovsky
2018-09-18 7:15 ` Pasi Kärkkäinen
2018-09-18 9:32 ` George Dunlap
2018-09-18 18:09 ` Boris Ostrovsky
2018-09-19 9:05 ` Roger Pau Monné
2018-10-03 15:51 ` Pasi Kärkkäinen
2018-10-08 14:32 ` Boris Ostrovsky
2019-08-26 21:05 ` Pasi Kärkkäinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171208202424.GC12367@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=Govinda.Tatti@Oracle.COM \
--cc=JBeulich@suse.com \
--cc=bhelgaas@google.com \
--cc=boris.ostrovsky@Oracle.COM \
--cc=jgross@suse.com \
--cc=konrad.wilk@Oracle.COM \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®