From: "Jan Beulich" <JBeulich@suse.com>
To: "Govinda Tatti" <Govinda.Tatti@Oracle.COM>
Cc: <roger.pau@citrix.com>, <bhelgaas@google.com>,
<xen-devel@lists.xenproject.org>, <boris.ostrovsky@Oracle.COM>,
<konrad.wilk@Oracle.COM>, "Juergen Gross" <jgross@suse.com>,
<linux-kernel@vger.kernel.org>, <linux-pci@vger.kernel.org>
Subject: Re: [PATCH V3 2/2] Xen/PCIback: Implement PCI flr/slot/bus reset with 'reset' SysFS attribute
Date: Tue, 12 Dec 2017 08:01:45 -0700 [thread overview]
Message-ID: <5A2FFD690200007800196DFB@prv-mh.provo.novell.com> (raw)
In-Reply-To: <8a3bc517-1255-4547-d244-5c400e44cc77@Oracle.COM>
>>> On 12.12.17 at 15:48, <Govinda.Tatti@Oracle.COM> wrote:
> Thanks Jan for your review comments. Please see below for my comments.
First of all - can you please do something about your reply style?
HTML mail should be avoided. You'll see that the (plain text) reply
as a result is rather hard to follow, too.
> --- a/Documentation/ABI/testing/sysfs-driver-pciback
> +++ b/Documentation/ABI/testing/sysfs-driver-pciback
> @@ -11,3 +11,18 @@ Description:
> #echo 00:19.0-E0:2:FF > /sys/bus/pci/drivers/pciback/quirks
> will allow the guest to read and write to the configuration
> register 0x0E.
> +
> +What: /sys/bus/pci/drivers/pciback/reset
> +Date: Dec 2017
> +KernelVersion: 4.15
> +Contact: xen-devel@lists.xenproject.org
> +Description:
> + An option to perform a flr/slot/bus reset when a PCI device
> + is owned by Xen PCI backend. Writing a string of DDDD:BB:DD.F
> SSSS:BB:DD.F (or else the D-s are ambiguous, the more that "domain"
> in Xen code is ambiguous anyway - I continue to be mislead by struct
> pcistub_device_id's domain field) Thanks for catching this issue. I will
> fix it.
>
>
> Also I assume the SSSS part is optional (default zero), which
> probably can and should be expressed in some way. SSSS can be 0 or
> non-zero, subject to system configuration.
The question isn't system configuration, but whether the field can
be omitted on input, with zero being assumed in such a case. That's
a common shorthand, considering that the vast majority of x86
(and maybe other) systems aren't using segments other than zero.
Jan
next prev parent reply other threads:[~2017-12-12 15:01 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 22:21 [PATCH V3 0/2] Xen/PCIback: PCI reset using " Govinda Tatti
2017-12-07 22:21 ` [PATCH V3 1/2] Drivers/PCI: Export pcie_has_flr() interface Govinda Tatti
2017-12-08 20:24 ` Bjorn Helgaas
2017-12-12 0:29 ` Govinda Tatti
2017-12-12 0:59 ` Bjorn Helgaas
2017-12-13 20:46 ` [Xen-devel] " Govinda Tatti
2017-12-13 21:24 ` Bjorn Helgaas
2017-12-14 12:52 ` Christoph Hellwig
2017-12-15 0:24 ` Bjorn Helgaas
2017-12-15 15:48 ` Govinda Tatti
2017-12-15 18:18 ` Bjorn Helgaas
2017-12-15 20:01 ` Govinda Tatti
2017-12-18 3:09 ` Alexey Kardashevskiy
2017-12-18 12:26 ` Christoph Hellwig
2017-12-18 17:22 ` Govinda Tatti
2018-09-09 18:59 ` Pasi Kärkkäinen
2018-09-10 2:33 ` Sinan Kaya
2018-09-10 9:52 ` Pasi Kärkkäinen
2018-09-10 17:04 ` Sinan Kaya
2017-12-12 15:07 ` Christoph Hellwig
2017-12-07 22:21 ` [PATCH V3 2/2] Xen/PCIback: Implement PCI flr/slot/bus reset with 'reset' SysFS attribute Govinda Tatti
2017-12-08 9:34 ` Jan Beulich
2017-12-12 15:01 ` Govinda Tatti
[not found] ` <8a3bc517-1255-4547-d244-5c400e44cc77@Oracle.COM>
2017-12-12 15:01 ` Jan Beulich [this message]
2017-12-12 15:14 ` [Xen-devel] " Govinda Tatti
2017-12-15 19:52 ` Govinda Tatti
2017-12-18 7:36 ` Jan Beulich
2017-12-18 17:32 ` Boris Ostrovsky
2018-09-16 11:43 ` [Xen-devel] " Pasi Kärkkäinen
2018-09-17 18:06 ` Boris Ostrovsky
2018-09-18 7:15 ` Pasi Kärkkäinen
2018-09-18 9:32 ` George Dunlap
2018-09-18 18:09 ` Boris Ostrovsky
2018-09-19 9:05 ` Roger Pau Monné
2018-10-03 15:51 ` Pasi Kärkkäinen
2018-10-08 14:32 ` Boris Ostrovsky
2019-08-26 21:05 ` Pasi Kärkkäinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A2FFD690200007800196DFB@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=Govinda.Tatti@Oracle.COM \
--cc=bhelgaas@google.com \
--cc=boris.ostrovsky@Oracle.COM \
--cc=jgross@suse.com \
--cc=konrad.wilk@Oracle.COM \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®