* [PATCH] virtio: make VIRTIO a menuconfig to ease disabling it all
@ 2017-12-09 15:26 Vincent Legoll
2017-12-21 6:44 ` Andrei Vagin
2017-12-21 10:53 ` [PATCH] " Michael Ellerman
0 siblings, 2 replies; 13+ messages in thread
From: Vincent Legoll @ 2017-12-09 15:26 UTC (permalink / raw)
To: mst, jasowang, virtualization, linux-kernel; +Cc: Vincent Legoll
No need to get into the submenu to disable all VIRTIO-related
config entries.
This makes it easier to disable all VIRTIO config options
without entering the submenu. It will also enable one
to see that en/dis-abled state from the outside menu.
This is only intended to change menuconfig UI, not change
the config dependencies.
Signed-off-by: Vincent Legoll <vincent.legoll@gmail.com>
---
drivers/virtio/Kconfig | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
index cff773f15b7e..d485a63a8233 100644
--- a/drivers/virtio/Kconfig
+++ b/drivers/virtio/Kconfig
@@ -5,7 +5,10 @@ config VIRTIO
bus, such as CONFIG_VIRTIO_PCI, CONFIG_VIRTIO_MMIO, CONFIG_RPMSG
or CONFIG_S390_GUEST.
-menu "Virtio drivers"
+menuconfig VIRTIO_MENU
+ bool "Virtio drivers"
+
+if VIRTIO_MENU
config VIRTIO_PCI
tristate "PCI driver for virtio devices"
@@ -79,4 +82,4 @@ config VIRTIO_MMIO_CMDLINE_DEVICES
If unsure, say 'N'.
-endmenu
+endif # VIRTIO_MENU
--
2.14.1
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: virtio: make VIRTIO a menuconfig to ease disabling it all
2017-12-09 15:26 [PATCH] virtio: make VIRTIO a menuconfig to ease disabling it all Vincent Legoll
@ 2017-12-21 6:44 ` Andrei Vagin
2017-12-21 10:53 ` [PATCH] " Michael Ellerman
1 sibling, 0 replies; 13+ messages in thread
From: Andrei Vagin @ 2017-12-21 6:44 UTC (permalink / raw)
To: Vincent Legoll; +Cc: mst, jasowang, virtualization, linux-kernel
On Sat, Dec 09, 2017 at 04:26:57PM +0100, Vincent Legoll wrote:
> No need to get into the submenu to disable all VIRTIO-related
> config entries.
>
> This makes it easier to disable all VIRTIO config options
> without entering the submenu. It will also enable one
> to see that en/dis-abled state from the outside menu.
>
> This is only intended to change menuconfig UI, not change
> the config dependencies.
>
> Signed-off-by: Vincent Legoll <vincent.legoll@gmail.com>
> ---
> drivers/virtio/Kconfig | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
> index cff773f15b7e..d485a63a8233 100644
> --- a/drivers/virtio/Kconfig
> +++ b/drivers/virtio/Kconfig
> @@ -5,7 +5,10 @@ config VIRTIO
> bus, such as CONFIG_VIRTIO_PCI, CONFIG_VIRTIO_MMIO, CONFIG_RPMSG
> or CONFIG_S390_GUEST.
>
> -menu "Virtio drivers"
> +menuconfig VIRTIO_MENU
> + bool "Virtio drivers"
Hi Vincent,
make localyesconfig and make localmodconfig doesn't work with this
patch.
My scenario looks like this:
* Create a virtual machine with Ubuntu 14.04 in GCE
* git clone git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
* cd linux-next
* curl -o .config https://raw.githubusercontent.com/avagin/criu/linux-next/scripts/linux-next-config
* make localyesconfig
Without this patch:
$ cat .config | grep VIRTIO
CONFIG_BLK_MQ_VIRTIO=y
CONFIG_VIRTIO_BLK=y
# CONFIG_VIRTIO_BLK_SCSI is not set
CONFIG_SCSI_VIRTIO=y
CONFIG_VIRTIO_NET=y
CONFIG_VIRTIO_CONSOLE=y
# CONFIG_HW_RANDOM_VIRTIO is not set
CONFIG_VIRTIO=y
CONFIG_VIRTIO_PCI=y
CONFIG_VIRTIO_PCI_LEGACY=y
CONFIG_VIRTIO_BALLOON=y
# CONFIG_VIRTIO_INPUT is not set
CONFIG_VIRTIO_MMIO=y
CONFIG_VIRTIO_MMIO_CMDLINE_DEVICES=y
# CONFIG_RPMSG_VIRTIO is not set
# CONFIG_CRYPTO_DEV_VIRTIO is not set
With this patch:
$ cat .config | grep VIRTIO
CONFIG_BLK_MQ_VIRTIO=y
# CONFIG_VIRTIO_BLK is not set
CONFIG_SCSI_VIRTIO=y
# CONFIG_VIRTIO_NET is not set
CONFIG_CAIF_VIRTIO=y
# CONFIG_VIRTIO_CONSOLE is not set
# CONFIG_HW_RANDOM_VIRTIO is not set
CONFIG_VIRTIO=y
# CONFIG_VIRTIO_MENU is not set
# CONFIG_RPMSG_VIRTIO is not set
# CONFIG_CRYPTO_DEV_VIRTIO is not set
You can see that with this patch CONFIG_VIRTIO_BLK is not set.
It is wrong, and the kernel with this config will not be able to boot.
We can add "default y" to fix this problem.
https://travis-ci.org/avagin/linux/jobs/313348334
https://travis-ci.org/avagin/linux/jobs/318491188
Thanks,
Andrei
> +
> +if VIRTIO_MENU
>
> config VIRTIO_PCI
> tristate "PCI driver for virtio devices"
> @@ -79,4 +82,4 @@ config VIRTIO_MMIO_CMDLINE_DEVICES
>
> If unsure, say 'N'.
>
> -endmenu
> +endif # VIRTIO_MENU
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] virtio: make VIRTIO a menuconfig to ease disabling it all
2017-12-09 15:26 [PATCH] virtio: make VIRTIO a menuconfig to ease disabling it all Vincent Legoll
2017-12-21 6:44 ` Andrei Vagin
@ 2017-12-21 10:53 ` Michael Ellerman
2017-12-21 16:23 ` Vincent Legoll
1 sibling, 1 reply; 13+ messages in thread
From: Michael Ellerman @ 2017-12-21 10:53 UTC (permalink / raw)
To: Vincent Legoll, mst, jasowang, virtualization, linux-kernel
Cc: Vincent Legoll
Vincent Legoll <vincent.legoll@gmail.com> writes:
> No need to get into the submenu to disable all VIRTIO-related
> config entries.
>
> This makes it easier to disable all VIRTIO config options
> without entering the submenu. It will also enable one
> to see that en/dis-abled state from the outside menu.
>
> This is only intended to change menuconfig UI, not change
> the config dependencies.
>
> Signed-off-by: Vincent Legoll <vincent.legoll@gmail.com>
> ---
> drivers/virtio/Kconfig | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
> index cff773f15b7e..d485a63a8233 100644
> --- a/drivers/virtio/Kconfig
> +++ b/drivers/virtio/Kconfig
> @@ -5,7 +5,10 @@ config VIRTIO
> bus, such as CONFIG_VIRTIO_PCI, CONFIG_VIRTIO_MMIO, CONFIG_RPMSG
> or CONFIG_S390_GUEST.
>
> -menu "Virtio drivers"
> +menuconfig VIRTIO_MENU
> + bool "Virtio drivers"
> +
> +if VIRTIO_MENU
This breaks all existing .configs *and* defconfigs that use VIRTIO.
Please don't do that.
If you make it default y then everything will continue to work.
cheers
diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
index d485a63a8233..35897649c24f 100644
--- a/drivers/virtio/Kconfig
+++ b/drivers/virtio/Kconfig
@@ -7,6 +7,7 @@ config VIRTIO
menuconfig VIRTIO_MENU
bool "Virtio drivers"
+ default y
if VIRTIO_MENU
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] virtio: make VIRTIO a menuconfig to ease disabling it all
2017-12-21 10:53 ` [PATCH] " Michael Ellerman
@ 2017-12-21 16:23 ` Vincent Legoll
2017-12-22 2:12 ` Michael Ellerman
0 siblings, 1 reply; 13+ messages in thread
From: Vincent Legoll @ 2017-12-21 16:23 UTC (permalink / raw)
To: Michael Ellerman; +Cc: mst, jasowang, virtualization, Linux Kernel ML
Hello,
thanks for the help, and sorry for the poor patch,
On Thu, Dec 21, 2017 at 11:53 AM, Michael Ellerman <mpe@ellerman.id.au> wrote:
> This breaks all existing .configs *and* defconfigs that use VIRTIO.
>
> Please don't do that.
>
> If you make it default y then everything will continue to work.
Do you want me to respin it with the added default ?
Tchuss
--
Vincent Legoll
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] virtio: make VIRTIO a menuconfig to ease disabling it all
2017-12-21 16:23 ` Vincent Legoll
@ 2017-12-22 2:12 ` Michael Ellerman
2018-01-02 22:40 ` Michael Ellerman
0 siblings, 1 reply; 13+ messages in thread
From: Michael Ellerman @ 2017-12-22 2:12 UTC (permalink / raw)
To: Vincent Legoll; +Cc: mst, jasowang, virtualization, Linux Kernel ML
Vincent Legoll <vincent.legoll@gmail.com> writes:
> Hello,
>
> thanks for the help, and sorry for the poor patch,
>
> On Thu, Dec 21, 2017 at 11:53 AM, Michael Ellerman <mpe@ellerman.id.au> wrote:
>> This breaks all existing .configs *and* defconfigs that use VIRTIO.
>>
>> Please don't do that.
>>
>> If you make it default y then everything will continue to work.
>
> Do you want me to respin it with the added default ?
Yes please, either that or revert it.
cheers
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] virtio: make VIRTIO a menuconfig to ease disabling it all
2017-12-22 2:12 ` Michael Ellerman
@ 2018-01-02 22:40 ` Michael Ellerman
2018-01-03 9:49 ` [PATCH, v2] virtio: make VIRTIO a menuconfig to ease disabling it Vincent Legoll
0 siblings, 1 reply; 13+ messages in thread
From: Michael Ellerman @ 2018-01-02 22:40 UTC (permalink / raw)
To: Vincent Legoll; +Cc: mst, jasowang, virtualization, Linux Kernel ML
Michael Ellerman <mpe@ellerman.id.au> writes:
> Vincent Legoll <vincent.legoll@gmail.com> writes:
>
>> Hello,
>>
>> thanks for the help, and sorry for the poor patch,
>>
>> On Thu, Dec 21, 2017 at 11:53 AM, Michael Ellerman <mpe@ellerman.id.au> wrote:
>>> This breaks all existing .configs *and* defconfigs that use VIRTIO.
>>>
>>> Please don't do that.
>>>
>>> If you make it default y then everything will continue to work.
>>
>> Do you want me to respin it with the added default ?
>
> Yes please, either that or revert it.
This still seems to be broken.
cheers
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH, v2] virtio: make VIRTIO a menuconfig to ease disabling it
2018-01-02 22:40 ` Michael Ellerman
@ 2018-01-03 9:49 ` Vincent Legoll
2018-01-03 9:49 ` [PATCH] [PATCH] virtio: make VIRTIO a menuconfig to ease disabling it all Vincent Legoll
0 siblings, 1 reply; 13+ messages in thread
From: Vincent Legoll @ 2018-01-03 9:49 UTC (permalink / raw)
To: mst, jasowang, virtualization, linux-kernel; +Cc: Vincent Legoll
No need to get into the submenu to disable all VIRTIO-related
config entries.
This makes it easier to disable all VIRTIO config options
without entering the submenu. It will also enable one
to see that en/dis-abled state from the outside menu.
This is only intended to change menuconfig UI, not change
the config dependencies.
v2: Added "default y" to avoid breaking existing configs
Signed-off-by: Vincent Legoll <vincent.legoll@gmail.com>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] [PATCH] virtio: make VIRTIO a menuconfig to ease disabling it all
2018-01-03 9:49 ` [PATCH, v2] virtio: make VIRTIO a menuconfig to ease disabling it Vincent Legoll
@ 2018-01-03 9:49 ` Vincent Legoll
2018-01-07 3:25 ` Randy Dunlap
0 siblings, 1 reply; 13+ messages in thread
From: Vincent Legoll @ 2018-01-03 9:49 UTC (permalink / raw)
To: mst, jasowang, virtualization, linux-kernel; +Cc: Vincent Legoll
No need to get into the submenu to disable all VIRTIO-related
config entries.
This makes it easier to disable all VIRTIO config options
without entering the submenu. It will also enable one
to see that en/dis-abled state from the outside menu.
This is only intended to change menuconfig UI, not change
the config dependencies.
v2: add "default y" to avoid breaking existing configs
Signed-off-by: Vincent Legoll <vincent.legoll@gmail.com>
---
drivers/virtio/Kconfig | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
index cff773f15b7e..290a1875e1d3 100644
--- a/drivers/virtio/Kconfig
+++ b/drivers/virtio/Kconfig
@@ -5,7 +5,11 @@ config VIRTIO
bus, such as CONFIG_VIRTIO_PCI, CONFIG_VIRTIO_MMIO, CONFIG_RPMSG
or CONFIG_S390_GUEST.
-menu "Virtio drivers"
+menuconfig VIRTIO_MENU
+ bool "Virtio drivers"
+ default y
+
+if VIRTIO_MENU
config VIRTIO_PCI
tristate "PCI driver for virtio devices"
@@ -79,4 +83,4 @@ config VIRTIO_MMIO_CMDLINE_DEVICES
If unsure, say 'N'.
-endmenu
+endif # VIRTIO_MENU
--
2.11.0
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] [PATCH] virtio: make VIRTIO a menuconfig to ease disabling it all
2018-01-03 9:49 ` [PATCH] [PATCH] virtio: make VIRTIO a menuconfig to ease disabling it all Vincent Legoll
@ 2018-01-07 3:25 ` Randy Dunlap
2018-01-07 11:33 ` Vincent Legoll
0 siblings, 1 reply; 13+ messages in thread
From: Randy Dunlap @ 2018-01-07 3:25 UTC (permalink / raw)
To: Vincent Legoll, mst, jasowang, virtualization, linux-kernel
On 01/03/18 01:49, Vincent Legoll wrote:
> No need to get into the submenu to disable all VIRTIO-related
> config entries.
>
> This makes it easier to disable all VIRTIO config options
> without entering the submenu. It will also enable one
> to see that en/dis-abled state from the outside menu.
>
> This is only intended to change menuconfig UI, not change
> the config dependencies.
>
> v2: add "default y" to avoid breaking existing configs
>
> Signed-off-by: Vincent Legoll <vincent.legoll@gmail.com>
For a single patch (not 2 or more in a series), please just use one
email with the patch description etc. in it. No need for a cover letter.
> ---
> drivers/virtio/Kconfig | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
> index cff773f15b7e..290a1875e1d3 100644
> --- a/drivers/virtio/Kconfig
> +++ b/drivers/virtio/Kconfig
> @@ -5,7 +5,11 @@ config VIRTIO
> bus, such as CONFIG_VIRTIO_PCI, CONFIG_VIRTIO_MMIO, CONFIG_RPMSG
> or CONFIG_S390_GUEST.
>
> -menu "Virtio drivers"
> +menuconfig VIRTIO_MENU
> + bool "Virtio drivers"
> + default y
The 2 lines above should be indented only with 1 tab. They should not line up
with the help text above (help text is indented more than other Kconfig lines).
After that little style thing is fixed, you can add:
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org> # works for me
and even though this will disable the drivers that are listed immediately
inside this if/endif block, there are several other drivers that select VIRTIO,
so it can be slightly tricky to figure out what is causing CONFIG_VIRTIO
to be enabled after having disabled CONFIG_VIRTIO_MENU.
Thanks.
> +
> +if VIRTIO_MENU
>
> config VIRTIO_PCI
> tristate "PCI driver for virtio devices"
> @@ -79,4 +83,4 @@ config VIRTIO_MMIO_CMDLINE_DEVICES
>
> If unsure, say 'N'.
>
> -endmenu
> +endif # VIRTIO_MENU
>
--
~Randy
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] virtio: make VIRTIO a menuconfig to ease disabling it all
2018-01-07 3:25 ` Randy Dunlap
@ 2018-01-07 11:33 ` Vincent Legoll
2018-01-23 4:31 ` Ping " Michael Ellerman
0 siblings, 1 reply; 13+ messages in thread
From: Vincent Legoll @ 2018-01-07 11:33 UTC (permalink / raw)
To: Michael S. Tsirkin, Jason Wang, virtualization, linux-kernel
Cc: Randy Dunlap, Vincent Legoll
No need to get into the submenu to disable all VIRTIO-related
config entries.
This makes it easier to disable all VIRTIO config options
without entering the submenu. It will also enable one
to see that en/dis-abled state from the outside menu.
This is only intended to change menuconfig UI, not change
the config dependencies.
v2: Added "default y" to avoid breaking existing configs
v3: Fixed wrong indentation, added *-by from Randy
Signed-off-by: Vincent Legoll <vincent.legoll@gmail.com>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org> # works for me
---
drivers/virtio/Kconfig | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
index cff773f15b7e..35897649c24f 100644
--- a/drivers/virtio/Kconfig
+++ b/drivers/virtio/Kconfig
@@ -5,7 +5,11 @@ config VIRTIO
bus, such as CONFIG_VIRTIO_PCI, CONFIG_VIRTIO_MMIO, CONFIG_RPMSG
or CONFIG_S390_GUEST.
-menu "Virtio drivers"
+menuconfig VIRTIO_MENU
+ bool "Virtio drivers"
+ default y
+
+if VIRTIO_MENU
config VIRTIO_PCI
tristate "PCI driver for virtio devices"
@@ -79,4 +83,4 @@ config VIRTIO_MMIO_CMDLINE_DEVICES
If unsure, say 'N'.
-endmenu
+endif # VIRTIO_MENU
--
2.14.1
^ permalink raw reply [flat|nested] 13+ messages in thread
* Ping Re: [PATCH] virtio: make VIRTIO a menuconfig to ease disabling it all
2018-01-07 11:33 ` Vincent Legoll
@ 2018-01-23 4:31 ` Michael Ellerman
2018-01-23 8:08 ` Vincent Legoll
0 siblings, 1 reply; 13+ messages in thread
From: Michael Ellerman @ 2018-01-23 4:31 UTC (permalink / raw)
To: Vincent Legoll, Michael S. Tsirkin, Jason Wang, virtualization,
linux-kernel
Cc: Randy Dunlap, Vincent Legoll
Vincent Legoll <vincent.legoll@gmail.com> writes:
> No need to get into the submenu to disable all VIRTIO-related
> config entries.
>
> This makes it easier to disable all VIRTIO config options
> without entering the submenu. It will also enable one
> to see that en/dis-abled state from the outside menu.
>
> This is only intended to change menuconfig UI, not change
> the config dependencies.
>
> v2: Added "default y" to avoid breaking existing configs
> v3: Fixed wrong indentation, added *-by from Randy
>
> Signed-off-by: Vincent Legoll <vincent.legoll@gmail.com>
> Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
> Tested-by: Randy Dunlap <rdunlap@infradead.org> # works for me
> ---
> drivers/virtio/Kconfig | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
This has been broken in linux-next for ~6 weeks now, can we please merge
this and get it fixed.
cheers
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Ping Re: [PATCH] virtio: make VIRTIO a menuconfig to ease disabling it all
2018-01-23 4:31 ` Ping " Michael Ellerman
@ 2018-01-23 8:08 ` Vincent Legoll
2018-01-28 10:14 ` Michael Ellerman
0 siblings, 1 reply; 13+ messages in thread
From: Vincent Legoll @ 2018-01-23 8:08 UTC (permalink / raw)
To: Michael Ellerman, sfr
Cc: Michael S. Tsirkin, Jason Wang, virtualization, linux-kernel,
Randy Dunlap
On 1/23/18, Michael Ellerman <mpe@ellerman.id.au> wrote:
> This has been broken in linux-next for ~6 weeks now, can we please merge
> this and get it fixed.
Added Stephen Rothwell to cc
--
Vincent Legoll
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Ping Re: [PATCH] virtio: make VIRTIO a menuconfig to ease disabling it all
2018-01-23 8:08 ` Vincent Legoll
@ 2018-01-28 10:14 ` Michael Ellerman
0 siblings, 0 replies; 13+ messages in thread
From: Michael Ellerman @ 2018-01-28 10:14 UTC (permalink / raw)
To: Michael S. Tsirkin, Jason Wang, Vincent Legoll, sfr
Cc: virtualization, linux-kernel, Randy Dunlap
Vincent Legoll <vincent.legoll@gmail.com> writes:
> On 1/23/18, Michael Ellerman <mpe@ellerman.id.au> wrote:
>> This has been broken in linux-next for ~6 weeks now, can we please merge
>> this and get it fixed.
>
> Added Stephen Rothwell to cc
It should be fixed in the virtio tree, which the other Michael and Jason
maintain AFAIK.
cheers
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2018-01-28 10:14 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-09 15:26 [PATCH] virtio: make VIRTIO a menuconfig to ease disabling it all Vincent Legoll
2017-12-21 6:44 ` Andrei Vagin
2017-12-21 10:53 ` [PATCH] " Michael Ellerman
2017-12-21 16:23 ` Vincent Legoll
2017-12-22 2:12 ` Michael Ellerman
2018-01-02 22:40 ` Michael Ellerman
2018-01-03 9:49 ` [PATCH, v2] virtio: make VIRTIO a menuconfig to ease disabling it Vincent Legoll
2018-01-03 9:49 ` [PATCH] [PATCH] virtio: make VIRTIO a menuconfig to ease disabling it all Vincent Legoll
2018-01-07 3:25 ` Randy Dunlap
2018-01-07 11:33 ` Vincent Legoll
2018-01-23 4:31 ` Ping " Michael Ellerman
2018-01-23 8:08 ` Vincent Legoll
2018-01-28 10:14 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®