* [PATCH] crypto: stm32: fix modular build
@ 2017-12-11 11:47 Arnd Bergmann
2017-12-11 14:31 ` Fabien DESSENNE
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2017-12-11 11:47 UTC (permalink / raw)
To: Herbert Xu, David S. Miller
Cc: Arnd Bergmann, Maxime Coquelin, Alexandre Torgue,
Fabien DESSENNE, linux-crypto, linux-arm-kernel, linux-kernel
Building the stm32 crypto suport as a loadable module causes a build
failure from a simple typo:
drivers/crypto/stm32/stm32-cryp.c:1035:25: error: 'sti_dt_ids' undeclared here (not in a function); did you mean 'stm32_dt_ids'?
This renames the reference to point to the correct symbol.
Fixes: 9e054ec21ef8 ("crypto: stm32 - Support for STM32 CRYP crypto module")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/crypto/stm32/stm32-cryp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/stm32/stm32-cryp.c b/drivers/crypto/stm32/stm32-cryp.c
index 459755940632..cf1dddbeaa2c 100644
--- a/drivers/crypto/stm32/stm32-cryp.c
+++ b/drivers/crypto/stm32/stm32-cryp.c
@@ -1032,7 +1032,7 @@ static const struct of_device_id stm32_dt_ids[] = {
{ .compatible = "st,stm32f756-cryp", },
{},
};
-MODULE_DEVICE_TABLE(of, sti_dt_ids);
+MODULE_DEVICE_TABLE(of, stm32_dt_ids);
static int stm32_cryp_probe(struct platform_device *pdev)
{
--
2.9.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] crypto: stm32: fix modular build
2017-12-11 11:47 [PATCH] crypto: stm32: fix modular build Arnd Bergmann
@ 2017-12-11 14:31 ` Fabien DESSENNE
0 siblings, 0 replies; 2+ messages in thread
From: Fabien DESSENNE @ 2017-12-11 14:31 UTC (permalink / raw)
To: Arnd Bergmann, Herbert Xu, David S. Miller
Cc: Maxime Coquelin, Alexandre TORGUE, linux-crypto,
linux-arm-kernel, linux-kernel
Hi Arnd,
This issue was reported a few days ago, and Herbert applied the patch 2
minutes before you send the mail (see
[https://www.mail-archive.com/linux-crypto@vger.kernel.org/msg29762.html]).
Anyway, thank you for reporting this.
Fabien
On 11/12/17 12:47, Arnd Bergmann wrote:
> Building the stm32 crypto suport as a loadable module causes a build
> failure from a simple typo:
>
> drivers/crypto/stm32/stm32-cryp.c:1035:25: error: 'sti_dt_ids' undeclared here (not in a function); did you mean 'stm32_dt_ids'?
>
> This renames the reference to point to the correct symbol.
>
> Fixes: 9e054ec21ef8 ("crypto: stm32 - Support for STM32 CRYP crypto module")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/crypto/stm32/stm32-cryp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/stm32/stm32-cryp.c b/drivers/crypto/stm32/stm32-cryp.c
> index 459755940632..cf1dddbeaa2c 100644
> --- a/drivers/crypto/stm32/stm32-cryp.c
> +++ b/drivers/crypto/stm32/stm32-cryp.c
> @@ -1032,7 +1032,7 @@ static const struct of_device_id stm32_dt_ids[] = {
> { .compatible = "st,stm32f756-cryp", },
> {},
> };
> -MODULE_DEVICE_TABLE(of, sti_dt_ids);
> +MODULE_DEVICE_TABLE(of, stm32_dt_ids);
>
> static int stm32_cryp_probe(struct platform_device *pdev)
> {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-11 14:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-11 11:47 [PATCH] crypto: stm32: fix modular build Arnd Bergmann
2017-12-11 14:31 ` Fabien DESSENNE
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®