From: Michele Dionisio <michele.dionisio@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
Michele Dionisio <michele.dionisio@gmail.com>
Subject: spi: davinci: Initialize dspi->done before any possible use of it
Date: Tue, 12 Dec 2017 11:10:48 +0100 [thread overview]
Message-ID: <20171212101048.28278-2-michele.dionisio@gmail.com> (raw)
In-Reply-To: <20171212101048.28278-1-michele.dionisio@gmail.com>
Signed-off-by: Michele Dionisio <michele.dionisio@gmail.com>
diff --git a/drivers/spi/spi-davinci.c b/drivers/spi/spi-davinci.c
index 6ddb6ef1fda4..60d59b003aa4 100644
--- a/drivers/spi/spi-davinci.c
+++ b/drivers/spi/spi-davinci.c
@@ -945,6 +945,8 @@ static int davinci_spi_probe(struct platform_device *pdev)
goto free_master;
}
+ init_completion(&dspi->done);
+
ret = platform_get_irq(pdev, 0);
if (ret == 0)
ret = -EINVAL;
@@ -1021,8 +1023,6 @@ static int davinci_spi_probe(struct platform_device *pdev)
dspi->get_rx = davinci_spi_rx_buf_u8;
dspi->get_tx = davinci_spi_tx_buf_u8;
- init_completion(&dspi->done);
-
/* Reset In/OUT SPI module */
iowrite32(0, dspi->base + SPIGCR0);
udelay(100);
next prev parent reply other threads:[~2017-12-12 10:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 10:10 Michele Dionisio
2017-12-12 10:10 ` Michele Dionisio [this message]
2017-12-12 11:17 ` Applied "spi: davinci: Initialize dspi->done before any possible use of it" to the spi tree Mark Brown
2017-12-12 10:16 ` spi: davinci: Initialize dspi->done before any possible use of it Mark Brown
2017-12-12 10:36 ` Michele Dionisio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171212101048.28278-2-michele.dionisio@gmail.com \
--to=michele.dionisio@gmail.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®