* spi: davinci: Initialize dspi->done before any possible use of it @ 2017-12-12 10:10 Michele Dionisio 2017-12-12 10:10 ` Michele Dionisio 2017-12-12 10:16 ` spi: davinci: Initialize dspi->done before any possible use of it Mark Brown 0 siblings, 2 replies; 5+ messages in thread From: Michele Dionisio @ 2017-12-12 10:10 UTC (permalink / raw) To: Mark Brown; +Cc: linux-spi, linux-kernel On SOC with multiple cpu (like omal l138) it is possible that spi periferic is already initialized when this module is loaded and it is possible to recieve interrupt when the modules is not sully initialized. ^ permalink raw reply [flat|nested] 5+ messages in thread
* spi: davinci: Initialize dspi->done before any possible use of it 2017-12-12 10:10 spi: davinci: Initialize dspi->done before any possible use of it Michele Dionisio @ 2017-12-12 10:10 ` Michele Dionisio 2017-12-12 11:17 ` Applied "spi: davinci: Initialize dspi->done before any possible use of it" to the spi tree Mark Brown 2017-12-12 10:16 ` spi: davinci: Initialize dspi->done before any possible use of it Mark Brown 1 sibling, 1 reply; 5+ messages in thread From: Michele Dionisio @ 2017-12-12 10:10 UTC (permalink / raw) To: Mark Brown; +Cc: linux-spi, linux-kernel, Michele Dionisio Signed-off-by: Michele Dionisio <michele.dionisio@gmail.com> diff --git a/drivers/spi/spi-davinci.c b/drivers/spi/spi-davinci.c index 6ddb6ef1fda4..60d59b003aa4 100644 --- a/drivers/spi/spi-davinci.c +++ b/drivers/spi/spi-davinci.c @@ -945,6 +945,8 @@ static int davinci_spi_probe(struct platform_device *pdev) goto free_master; } + init_completion(&dspi->done); + ret = platform_get_irq(pdev, 0); if (ret == 0) ret = -EINVAL; @@ -1021,8 +1023,6 @@ static int davinci_spi_probe(struct platform_device *pdev) dspi->get_rx = davinci_spi_rx_buf_u8; dspi->get_tx = davinci_spi_tx_buf_u8; - init_completion(&dspi->done); - /* Reset In/OUT SPI module */ iowrite32(0, dspi->base + SPIGCR0); udelay(100); ^ permalink raw reply [flat|nested] 5+ messages in thread
* Applied "spi: davinci: Initialize dspi->done before any possible use of it" to the spi tree 2017-12-12 10:10 ` Michele Dionisio @ 2017-12-12 11:17 ` Mark Brown 0 siblings, 0 replies; 5+ messages in thread From: Mark Brown @ 2017-12-12 11:17 UTC (permalink / raw) To: Michele Dionisio Cc: Mark Brown, Mark Brown, linux-spi, linux-kernel, linux-spi The patch spi: davinci: Initialize dspi->done before any possible use of it has been applied to the spi tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 87248dc79236575908568810a61e0953f738516f Mon Sep 17 00:00:00 2001 From: Michele Dionisio <michele.dionisio@gmail.com> Date: Tue, 12 Dec 2017 11:36:59 +0100 Subject: [PATCH] spi: davinci: Initialize dspi->done before any possible use of it On SOC with multiple cpu (like omal l138) it is possible that spi periferic is already initialized when this module is loaded and so it is possible to recieve interrupt when the modules is not fully initialized. this patch initialize dspi->done before refister the interrupt handler that use it Signed-off-by: Michele Dionisio <michele.dionisio@gmail.com> Signed-off-by: Mark Brown <broonie@kernel.org> --- drivers/spi/spi-davinci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-davinci.c b/drivers/spi/spi-davinci.c index 6ddb6ef1fda4..60d59b003aa4 100644 --- a/drivers/spi/spi-davinci.c +++ b/drivers/spi/spi-davinci.c @@ -945,6 +945,8 @@ static int davinci_spi_probe(struct platform_device *pdev) goto free_master; } + init_completion(&dspi->done); + ret = platform_get_irq(pdev, 0); if (ret == 0) ret = -EINVAL; @@ -1021,8 +1023,6 @@ static int davinci_spi_probe(struct platform_device *pdev) dspi->get_rx = davinci_spi_rx_buf_u8; dspi->get_tx = davinci_spi_tx_buf_u8; - init_completion(&dspi->done); - /* Reset In/OUT SPI module */ iowrite32(0, dspi->base + SPIGCR0); udelay(100); -- 2.15.1 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: spi: davinci: Initialize dspi->done before any possible use of it 2017-12-12 10:10 spi: davinci: Initialize dspi->done before any possible use of it Michele Dionisio 2017-12-12 10:10 ` Michele Dionisio @ 2017-12-12 10:16 ` Mark Brown 2017-12-12 10:36 ` Michele Dionisio 1 sibling, 1 reply; 5+ messages in thread From: Mark Brown @ 2017-12-12 10:16 UTC (permalink / raw) To: Michele Dionisio; +Cc: linux-spi, linux-kernel [-- Attachment #1: Type: text/plain, Size: 595 bytes --] On Tue, Dec 12, 2017 at 11:10:47AM +0100, Michele Dionisio wrote: > On SOC with multiple cpu (like omal l138) it is possible that spi periferic is already initialized when this module is loaded and it is possible to recieve interrupt when the modules is not sully initialized. Please include descriptions of what your patches are doing like this one in the changelog of the patch as covered in SubmittingPatches. Please also fix your mail client to word wrap within paragraphs at something substantially less than 80 columns. Doing this makes your messages much easier to read and reply to. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* spi: davinci: Initialize dspi->done before any possible use of it 2017-12-12 10:16 ` spi: davinci: Initialize dspi->done before any possible use of it Mark Brown @ 2017-12-12 10:36 ` Michele Dionisio 0 siblings, 0 replies; 5+ messages in thread From: Michele Dionisio @ 2017-12-12 10:36 UTC (permalink / raw) To: Mark Brown; +Cc: linux-spi, linux-kernel, Michele Dionisio On SOC with multiple cpu (like omal l138) it is possible that spi periferic is already initialized when this module is loaded and so it is possible to recieve interrupt when the modules is not fully initialized. this patch initialize dspi->done before refister the interrupt handler that use it Signed-off-by: Michele Dionisio <michele.dionisio@gmail.com> diff --git a/drivers/spi/spi-davinci.c b/drivers/spi/spi-davinci.c index 6ddb6ef1fda4..60d59b003aa4 100644 --- a/drivers/spi/spi-davinci.c +++ b/drivers/spi/spi-davinci.c @@ -945,6 +945,8 @@ static int davinci_spi_probe(struct platform_device *pdev) goto free_master; } + init_completion(&dspi->done); + ret = platform_get_irq(pdev, 0); if (ret == 0) ret = -EINVAL; @@ -1021,8 +1023,6 @@ static int davinci_spi_probe(struct platform_device *pdev) dspi->get_rx = davinci_spi_rx_buf_u8; dspi->get_tx = davinci_spi_tx_buf_u8; - init_completion(&dspi->done); - /* Reset In/OUT SPI module */ iowrite32(0, dspi->base + SPIGCR0); udelay(100); ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-12-12 11:17 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-12-12 10:10 spi: davinci: Initialize dspi->done before any possible use of it Michele Dionisio 2017-12-12 10:10 ` Michele Dionisio 2017-12-12 11:17 ` Applied "spi: davinci: Initialize dspi->done before any possible use of it" to the spi tree Mark Brown 2017-12-12 10:16 ` spi: davinci: Initialize dspi->done before any possible use of it Mark Brown 2017-12-12 10:36 ` Michele Dionisio
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®