From: Ingo Molnar <mingo@kernel.org>
To: Jonathan Corbet <corbet@lwn.net>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: sched: Update kerneldoc for sched_rr_get_interval()
Date: Tue, 12 Dec 2017 11:18:19 +0100 [thread overview]
Message-ID: <20171212101819.oq3mtmifqbovytgh@gmail.com> (raw)
In-Reply-To: <20171211162543.0e137538@lwn.net>
* Jonathan Corbet <corbet@lwn.net> wrote:
> On Mon, 11 Dec 2017 15:14:21 -0800
> Randy Dunlap <rdunlap@infradead.org> wrote:
>
> > On 12/11/2017 02:56 PM, Jonathan Corbet wrote:
> > > Commit abca5fc535a3e ("sched_rr_get_interval(): move compat to native, get
> > > rid of set_fs()") changed the prototype of that function but left the
> > > kerneldoc comments unchanged, leading to these docs-build warnings:
> > >
> > > ./kernel/sched/core.c:5113: warning: No description found for parameter 't'
> > > ./kernel/sched/core.c:5113: warning: Excess function parameter 'interval'
> > > description in 'sched_rr_get_interval'
> > >
> > > Update the documentation (noting that it's not a user-space address
> > > anymore) and make the docs build a little quieter.
> > >
> > > Signed-off-by: Jonathan Corbet <corbet@lwn.net>
> >
> > I sent a patch for this on DEC-03 to Al, Ingo, PeterZ, and LKML.
> > https://marc.info/?l=linux-kernel&m=151233595424349&w=2
> >
> > or I could ack your patch. :)
>
> OK, looking more closely, your patch is more correct than mine and is the
> one that should be applied. Sorry I didn't see it before.
Yeah, I have applied Randy's patch to the sched/urgent tree yesterday:
2064a5ab0470: sched/core: Fix kernel-doc warnings after code movement
It's still not pushed out though, because I'm chasing an (unrelated) regression.
Thanks,
Ingo
prev parent reply other threads:[~2017-12-12 10:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-11 22:56 Jonathan Corbet
2017-12-11 23:14 ` Randy Dunlap
2017-12-11 23:25 ` Jonathan Corbet
2017-12-12 10:18 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171212101819.oq3mtmifqbovytgh@gmail.com \
--to=mingo@kernel.org \
--cc=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®